envoy: Take xds mutator lock for map access #11541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'ackedVersions' was accessed in DeleteNode() without taking the mutex which can lead to mutating the map while readers are accessing it. Fixes: #11535 Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
added
kind/bug
|
test-me-please |
aanm
approved these changes
May 15, 2020
|
k8s 1.17 hit by #11313 |
|
Runtime hit by #11512 |
|
test-me-please |
|
@jrajahalme there's no need to re-run the tests if they hit known flakes. |
tklauser
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.5
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.6
in 1.6.9
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.6
in 1.6.9
maintainer-s-little-helper
bot
moved this from Backport pending to v1.6
to Backport done to v1.6
in 1.6.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'ackedVersions' was accessed in DeleteNode() without taking the mutex
which can lead to mutating the map while readers are accessing it.
Fixes: #11535
Signed-off-by: Jarno Rajahalme jarno@covalent.io