Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Replace managed etcd test with generic etcd test #11544

Merged
merged 2 commits into from May 15, 2020

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented May 15, 2020

No description provided.

tgraf added 2 commits May 15, 2020 12:28
The managed etcd feature is being deprecated soon. The test has been
unreliable due to etcd operator not being able to bring up etcd clusters
reliably. We want to ensure test coverage for the etcd backing though.
Convert the managed etcd test to a more generic test which uses
stateless etcd for a reliable outcome.

Fixes: #11181

Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. ci/flake This is a known failure that occurs in the tree. Please investigate me! labels May 15, 2020
@tgraf tgraf requested a review from a team as a code owner May 15, 2020 10:29
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 May 15, 2020
@tgraf tgraf marked this pull request as draft May 15, 2020 10:29
@tgraf
Copy link
Member Author

tgraf commented May 15, 2020

test-me-please

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 37.002% when pulling b3431dc on pr/tgraf/ci-replaced-managed-etcd-test into fac1802 on master.

@tgraf tgraf marked this pull request as ready for review May 15, 2020 13:08
@tgraf
Copy link
Member Author

tgraf commented May 15, 2020

Runtime:

K8s-1.17-Kernel-4.19

GKE:
Suite-k8s-1.14.K8sChaosTest Connectivity demo application Endpoint can still connect while Cilium is not running
Suite-k8s-1.14.K8sConformance Portmap Chaining Check connectivity-check compliance with portmap chainin
Suite-k8s-1.14.K8sFQDNTest Restart Cilium validate that FQDN is still working
Suite-k8s-1.14.K8sFQDNTest Validate that multiple specs are working correctly
Suite-k8s-1.14.K8sIstioTest Istio Bookinfo Demo Tests bookinfo inter-service connectivity

@tgraf tgraf marked this pull request as ready for review May 15, 2020 17:33
@tgraf tgraf merged commit 43a7bba into master May 15, 2020
1.8.0 automation moved this from In progress to Merged May 15, 2020
@tgraf tgraf deleted the pr/tgraf/ci-replaced-managed-etcd-test branch May 15, 2020 17:34
tklauser added a commit to cilium/packer-ci-build that referenced this pull request May 20, 2020
- cilium-{builder,runtime} images were updated in cilium/cilium#11542
- istio was updated in ciliu/cilium#11530
- etcd:v3.4.7 is needed for test/k8sT/manifests/etcd-deployment.yaml as
  of cilium/cilium#11544

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser added a commit to cilium/packer-ci-build that referenced this pull request May 20, 2020
- cilium-{builder,runtime} images were updated in cilium/cilium#11542
- istio was updated in ciliu/cilium#11530
- etcd:v3.4.7 is needed for test/k8sT/manifests/etcd-deployment.yaml as
  of cilium/cilium#11544

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me! release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants