CI: integrate hubble-relay and add initial hubble-relay tests #11549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
added
area/CI
|
test-me-please |
michi-covalent
approved these changes
May 15, 2020
gandro
approved these changes
May 16, 2020
|
Almost all tests failed with known flakes (managed etc, privileged unit tests). test-me-please |
|
retest-runtime |
nebril
requested changes
May 18, 2020
There was a problem hiding this comment.
Good changes! I have one small request - please add
--build-arg CILIUM_SHA=$(firstword $(GIT_VERSION))
to docker build call in hubble-relay build step in Makefile and
ARG CILIUM_SHA=""
LABEL cilium-sha=${CILIUM_SHA}
in hubble-relay dockerfile for all intermediate images as well as the final images to ensure that these get cleaned in GKE builds.
rolinh
force-pushed
the
pr/rolinh/ci-hubble-relay
branch
from
d95a9e5
to
9554d1e
Compare
nebril
requested changes
May 18, 2020
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
These tests are the same tests for L3/L4 and L7 flows that target the local hubble server but they target hubble-relay instead. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
force-pushed
the
pr/rolinh/ci-hubble-relay
branch
from
9554d1e
to
0163c9b
Compare
|
test-me-please |
|
test-me-please |
|
retest-runtime |
|
retest-4.9 |
gandro
approved these changes
May 20, 2020
nebril
approved these changes
May 20, 2020
|
Runtime tests failed on known flake #11512 (https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/295/), thus merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates hubble-relay into the CI and adds basic tests for hubble-relay.
Ref: #11228