Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Remove NodeCleanMetadata #11574

Merged
merged 1 commit into from May 18, 2020
Merged

test: Remove NodeCleanMetadata #11574

merged 1 commit into from May 18, 2020

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented May 18, 2020

This seems useless and only prolongs test duration

@tgraf
test: Remove NodeCleanMetadata
113bb88 
This seems useless and only prolongs test duration

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels May 18, 2020
@tgraf tgraf requested a review from a team as a code owner May 18, 2020 10:50
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 May 18, 2020
@tgraf
Copy link
Member Author

tgraf commented May 18, 2020

test-me-please

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 37.003% when pulling 113bb88 on pr/tgraf/ci-remove-cidr-annotation into 3cef02f on master.

brb
brb approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was introduced by f0741a6. Unfortunately, no context why it was needed. If tests are passing, then it should be fine to remove it.

@tgraf tgraf merged commit a2ff935 into master May 18, 2020
1.8.0 automation moved this from In progress to Merged May 18, 2020
@tgraf tgraf deleted the pr/tgraf/ci-remove-cidr-annotation branch May 18, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tgraf @coveralls @brb