Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix archiving artifacts in runtime jenkinsfile #11585

Merged
merged 1 commit into from May 21, 2020
Merged

ci: fix archiving artifacts in runtime jenkinsfile #11585

merged 1 commit into from May 21, 2020

Conversation

nebril
Copy link
Member

@nebril nebril commented May 18, 2020 •
edited

Fixes #11503

@nebril nebril requested a review from a team as a code owner May 18, 2020 15:51
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 May 18, 2020
@nebril
Copy link
Member Author

nebril commented May 18, 2020

test-runtime

@nebril nebril added the release-note/ci This PR makes changes to the CI. label May 18, 2020
@nebril nebril added the ci/flake This is a known failure that occurs in the tree. Please investigate me! label May 18, 2020
@coveralls
Copy link

coveralls commented May 18, 2020 •
edited

Coverage Status

Coverage increased (+0.007%) to 36.866% when pulling 794da94 on pr/fix-archive-runtime into d7f58e8 on master.

@nebril
Copy link
Member Author

nebril commented May 19, 2020

test-net-next

@nebril
Copy link
Member Author

nebril commented May 19, 2020

test-me-please

@nebril
Copy link
Member Author

nebril commented May 19, 2020

test-net-next

@nebril
Copy link
Member Author

nebril commented May 19, 2020

test-me-please

1 similar comment
@nebril
Copy link
Member Author

nebril commented May 19, 2020

test-me-please

@nebril
Copy link
Member Author

nebril commented May 19, 2020

retest-4.9

@nebril
Copy link
Member Author

nebril commented May 19, 2020

retest-4.19

@nebril
Copy link
Member Author

nebril commented May 19, 2020

retest-4.9

@nebril
Copy link
Member Author

nebril commented May 19, 2020

retest-4.19

@nebril
Copy link
Member Author

nebril commented May 20, 2020

retest-4.9

@nebril
Copy link
Member Author

nebril commented May 20, 2020

retest-gke

@nebril
ci: fix archiving artifacts in runtime jenkinsfile
794da94 
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril
Copy link
Member Author

nebril commented May 21, 2020

test-me-please

@nebril
Copy link
Member Author

nebril commented May 21, 2020

test-me-please

@nebril
Copy link
Member Author

nebril commented May 21, 2020 •
edited

Runtime run failed, but the artifacts are there: https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/337/ , we should merge after review

christarazi
christarazi approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

joestringer
joestringer approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes fix the bug, I don't think there's anything subtle we need to review this for is there? Any chance it could inadvertently break other artifact gathering?

@nebril
Copy link
Member Author

nebril commented May 21, 2020

Not really, merging this as is.

@nebril nebril merged commit 43ccfc9 into master May 21, 2020
1.8.0 automation moved this from In progress to Merged May 21, 2020
@nebril nebril deleted the pr/fix-archive-runtime branch May 21, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
ci/flake This is a known failure that occurs in the tree. Please investigate me! release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Runtime pipeline does not gather artifacts
4 participants
@nebril @coveralls @joestringer @christarazi