bpf: use per-cpu scratch space from xdp context to store meta data #11595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving to per-CPU scratch space instead avoids cache-misses and allows to keep the meta buffer always hot in cache. Only really adjust the pkt meta data space if we push up the stack to signal tc layer that we handled the service xlation. This improves the performance on my local testing by roughly +1.2Mpps. We don't perform an expensive clearing of the scratch space upon entering XDP as usage here is all self-contained and across tail calls we only read out what we populated beforehand. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
borkmann
added
pending-review
sig/datapath
|
test-me-please |
|
(ci failures due to quay being down) |
pchaigno
reviewed
May 19, 2020
brb
approved these changes
May 19, 2020
|
test-me-please |
1 similar comment
|
test-me-please |
|
retest-runtime (failed on #11512) |
|
retest-runtime |
1 similar comment
|
retest-runtime |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to per-CPU scratch space instead avoids cache-misses and allows
to keep the meta buffer always hot in cache. Only really adjust the
pkt meta data space if we push up the stack to signal tc layer that we
handled the service xlation. This improves the performance on my local
testing by roughly +1.2Mpps. We don't perform an expensive clearing of
the scratch space upon entering XDP as usage here is all self-contained
and across tail calls we only read out what we populated beforehand.
Signed-off-by: Daniel Borkmann daniel@iogearbox.net