install: Fix erroneous comment #11603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
release-note/misc
joestringer
force-pushed
the
submit/fix-configmap-comment
branch
from
b3b1fc9
to
ce867b2
Compare
christarazi
approved these changes
May 21, 2020
christarazi
added
the
dont-merge/needs-rebase
This comment implies that portmap is enabled, but the check immediately above also covers the case where there is no chaining mode. Remove the invalid comment. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
submit/fix-configmap-comment
branch
from
ce867b2
to
ca96471
Compare
joestringer
removed
the
dont-merge/needs-rebase
|
retest-4.9 |
aanm
approved these changes
May 25, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.5
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment implies that portmap is enabled, but the check immediately
above also covers the case where there is no chaining mode. Remove the
invalid comment.