doc: Use docker.io instead of quay.io #11606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was some confusion among new contributors whether they should use the Cilium image from docker.io or quay.io for running integration tests locally. Technically both are fine, but changing the documentation to use the Cilium image from docker.io to signify that it is considered a bit more official. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added
area/documentation
pchaigno
approved these changes
May 20, 2020
pchaigno
added
the
ready-to-merge
glibsm
reviewed
May 20, 2020
| @@ -460,7 +460,7 @@ An example invocation is | |||
|
|
|||
| :: | |||
|
|
|||
| CNI_INTEGRATION=eks K8S_VERSION=1.13 ginkgo --focus="K8s*" -noColor -- -cilium.provision=false -cilium.kubeconfig=`echo ~/.kube/config` -cilium.image="quay.io/cilium/cilium:latest" -cilium.operator-image="quay.io/cilium/operator:latest" -cilium.passCLIEnvironment=true | |||
| CNI_INTEGRATION=eks K8S_VERSION=1.13 ginkgo --focus="K8s*" -noColor -- -cilium.provision=false -cilium.kubeconfig=`echo ~/.kube/config` -cilium.image="docker.io/cilium/cilium:latest" -cilium.operator-image="docker.io/cilium/operator:latest" -cilium.passCLIEnvironment=true | |||
There was a problem hiding this comment.
just cilium/cilium:latest is also enough without the prefix
There was a problem hiding this comment.
yeah but i wasn't sure if
cilium/test/helpers/kubectl.go
Line 219 in da9a724
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some confusion among new contributors whether they should use
the Cilium image from docker.io or quay.io for running integration tests
locally. Technically both are fine, but changing the documentation to
use the Cilium image from docker.io to signify that it is considered a
bit more official.
Signed-off-by: Michi Mutsuzaki michi@isovalent.com