Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(k8s): Correct prometheus template #11611

Merged
merged 1 commit into from May 25, 2020

Conversation

sayboras
Copy link
Member

The original template prometheus.yaml was changed as part of
#6706.

Update path to point to monitoring-example.yaml instead.

Closes #11522

Signed-off-by: Tam Mach sayboras@yahoo.com

Correct prometheus template in integration test

@sayboras sayboras requested a review from a team as a code owner May 20, 2020 09:34
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Commit a856dd935f56571238b9b7c7f008904d0a62b964 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 20, 2020
@sayboras sayboras force-pushed the bugfix/fix-prometheus-path branch from a856dd9 to 4f58ea4 Compare May 20, 2020 14:57
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 20, 2020
@coveralls
Copy link

coveralls commented May 20, 2020

Coverage Status

Coverage decreased (-0.007%) to 36.85% when pulling 71f6572 on sayboras:bugfix/fix-prometheus-path into 123d03c on cilium:master.

The original template prometheus.yaml was changed as part of
cilium#6706.

Update path to point to monitoring-example.yaml instead.

Closes cilium#11522

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@sayboras sayboras force-pushed the bugfix/fix-prometheus-path branch from 4f58ea4 to 71f6572 Compare May 21, 2020 14:27
@aanm aanm merged commit 60786b6 into cilium:master May 25, 2020
1.8.0 automation moved this from In progress to Merged May 25, 2020
@sayboras sayboras deleted the bugfix/fix-prometheus-path branch May 25, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

CI: test/test_suite_test.go tries to apply nonexisting examples/kubernetes/addons/prometheus/prometheus.yaml
4 participants