Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: getpeername hook implementation for socket lb #11617

Merged
merged 10 commits into from May 23, 2020
Merged

bpf: getpeername hook implementation for socket lb #11617

merged 10 commits into from May 23, 2020

Conversation

borkmann
Copy link
Member

@borkmann borkmann commented May 20, 2020 •
edited

@borkmann borkmann added pending-review sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. labels May 20, 2020
@borkmann borkmann requested review from brb and a team May 20, 2020 15:00
@borkmann borkmann requested review from a team as code owners May 20, 2020 15:00
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

3 similar comments
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 May 20, 2020
@borkmann borkmann added release-note/major This PR introduces major new functionality to Cilium. and removed dont-merge/needs-release-note labels May 20, 2020
brb
brb reviewed May 20, 2020
View reviewed changes
vagrant_box_defaults.rb Outdated Show resolved Hide resolved
pchaigno
pchaigno requested changes May 21, 2020
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for Martynas's comment and one missing test case, LGTM!

bpf/include/bpf/builtins.h Show resolved Hide resolved
@borkmann borkmann force-pushed the pr/sock-lb-peername branch 2 times, most recently from 0d4d4ae to 974f580 Compare May 22, 2020 09:29
@coveralls
Copy link

coveralls commented May 22, 2020 •
edited

Coverage Status

Coverage increased (+0.03%) to 36.894% when pulling 1dcfcc8b55c16dc9696b5324e18c8b296783df17 on pr/sock-lb-peername into cc84c1d on master.

@borkmann borkmann requested a review from a team as a code owner May 22, 2020 13:54
@pchaigno
Copy link
Member

Does commit bpf: properly reverse xlate svc:port tuple from wildcarded lookups require a backport?

pchaigno
pchaigno approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@borkmann
Copy link
Member Author

borkmann commented May 22, 2020 •
edited

Does commit bpf: properly reverse xlate svc:port tuple from wildcarded lookups require a backport?

Yeah, I'll take care of it for 1.7. I've marked it as needs-backport for 1.7.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.7.5 May 22, 2020
@borkmann
Copy link
Member Author

test-me-please

@borkmann
Copy link
Member Author

retest-4.19

@borkmann
Copy link
Member Author

test-me-please

@borkmann
Copy link
Member Author

restest-4.9

@borkmann
Copy link
Member Author

test-me-please

@borkmann
Copy link
Member Author

retest-net-next

@borkmann
Copy link
Member Author

retest-runtime

@borkmann
Copy link
Member Author

retest-net-next

@borkmann
Copy link
Member Author

vbox error:

10:59:40  Progress state: VBOX_E_OBJECT_IN_USE
10:59:40  VBoxManage: error: Machine delete failed
10:59:40  VBoxManage: error: Cannot close medium '/root/VirtualBox VMs/ubuntu-18.04.4-amd64-55_1590229760245_39345/ubuntu-18.04.4-amd64-55-disk001.vmdk' because it has 2 child media
10:59:40  VBoxManage: error: Details: code VBOX_E_OBJECT_IN_USE (0x80bb000c), component MediumWrap, interface IMedium
10:59:40  VBoxManage: error: Context: "RTEXITCODE handleUnregisterVM(HandlerArg*)" at line 162 of file VBoxManageMisc.cpp
10:59:40  VBoxManage: error: Machine 'dc5268d5-da68-4fc4-9b13-921a35692493' is not currently running
10:59:40  0%...10%...20%...30%...40%...50%...60%...70%...80%...90%...100%
10:59:40  VBoxManage: error: Machine '3c6abf7b-0259-4188-973c-e78ed91e0dac' is not currently running
10:59:42  0%...10%...20%...30%...40%...50%...60%...70%...80%...90%...100%

@borkmann
Copy link
Member Author

retest-net-next

2 similar comments
@borkmann
Copy link
Member Author

retest-net-next

@borkmann
Copy link
Member Author

retest-net-next

@borkmann borkmann merged commit 5a8501a into master May 23, 2020
1.8.0 automation moved this from In progress to Merged May 23, 2020
@borkmann borkmann deleted the pr/sock-lb-peername branch May 23, 2020 18:12
@tklauser tklauser mentioned this pull request Jun 3, 2020
Merged
@christarazi christarazi mentioned this pull request Jun 4, 2020
Merged
@joestringer joestringer mentioned this pull request Jun 8, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.5 Jun 8, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.5 Jun 8, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Needs backport from master in 1.7.5 Jun 9, 2020
@aanm aanm removed this from Needs backport from master in 1.7.5 Jun 12, 2020
@aanm aanm added this to Needs backport from master in 1.7.6 Jun 12, 2020
@aanm aanm removed this from Needs backport from master in 1.7.6 Jul 3, 2020
@tklauser tklauser mentioned this pull request Jul 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb left review comments

@pchaigno pchaigno pchaigno approved these changes

Assignees
No one assigned
Labels
release-note/major This PR introduces major new functionality to Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cilium, host reachable services: implement getpeername hook
5 participants
@borkmann @coveralls @pchaigno @brb @joestringer