Support DNS matchPattern="*" to match "." #11633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
release-note/minor
|
test-me-please |
|
lgtm, but i'm not sure if this was simply an oversight or there was some rationale for not matching this. i guess @raybejjani would know. |
jrajahalme
approved these changes
May 21, 2020
DNS servers may request a list of root nameservers by forming an NS request for ".". We have received reports that when applying a visibility policy with the DNS matchPattern "*", DNS requests of this kind were being dropped in the proxy. Fix this by extending the visibility match "*" to explicitly match on either "[validdnscharacters].", or ".". If the matchPattern is more complicated than simply "*", do not match on ".". Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
submit/dns-match-root-ns
branch
from
0f011f8
to
ea739d8
Compare
|
test-me-please |
pchaigno
approved these changes
May 21, 2020
nebril
approved these changes
May 21, 2020
There was a problem hiding this comment.
based on docs it seems like this is intended behaviour: * alone matches all names, and inserts all cached DNS IPs into this rule. via https://docs.cilium.io/en/v1.7/policy/language/#dns-based
tgraf
approved these changes
May 21, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.5
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.5
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.6
in 1.6.9
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.6
in 1.6.9
maintainer-s-little-helper
bot
moved this from Backport pending to v1.6
to Backport done to v1.6
in 1.6.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNS servers may request a list of root nameservers by forming an NS
request for
.. We have received reports that when applying avisibility policy with the DNS matchPattern
*, DNS requests of thiskind were being dropped in the proxy.
Fix this by extending the visibility match
*to explicitly match oneither
[validdnscharacters]., or.. If the matchPattern is morecomplicated than simply
*, do not match on..