delete pkg/hubble/ipcache and GetIPIdentity func from ipcache #11652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
added
kind/cleanup
gandro
approved these changes
May 22, 2020
michi-covalent
approved these changes
May 22, 2020
glibsm
approved these changes
May 22, 2020
This commit updates hubble parser's IPGetter interface so that the interface methods match existing ones in cilium's ipcache package that provide information that is necessary for hubble's parsers. As a consequence, the GetIPIdentity method can be removed from cilium's ipcache. This method was added when hubble was initially embedded into cilium and never made its way to a cilium release. Another consequence of this change is that package pkg/hubble/ipcache can be removed entirely. It was a remnant from the time when hubble was running as standalone and had to replicate its own IP cache from cilium's. This commit does not make functional changes. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
force-pushed
the
pr/rolinh/hubble-delete-ipcache
branch
from
7484c62
to
fafab22
Compare
|
test-me-please |
aanm
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates hubble parser's IPGetter interface so that the
interface methods match existing ones in cilium's ipcache package that
provide information that is necessary for hubble's parsers.
As a consequence, the GetIPIdentity method can be removed from cilium's
ipcache. This method was added when hubble was initially embedded into
cilium and never made its way to a cilium release.
Another consequence of this change is that package pkg/hubble/ipcache
can be removed entirely. It was a remnant from the time when hubble was
running as standalone and had to replicate its own IP cache from
cilium's.
This commit does not make functional changes.