Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Check whether pod is being terminated before deleting it #11655

Merged
merged 1 commit into from May 25, 2020

Conversation

nebril
Copy link
Member

@nebril nebril commented May 22, 2020

Some pods might be already being terminated in GKE clusters, which
caused test suite to fail. This change adds a check to make sure we
don't try to delete terminating pods.

Some pods might be already being terminated in GKE clusters, which
caused test suite to fail. This change adds a check to make sure we
don't try to delete terminating pods.

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril requested a review from a team as a code owner May 22, 2020 15:11
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@nebril
Copy link
Member Author

nebril commented May 22, 2020

test-gke

@nebril nebril added the release-note/ci This PR makes changes to the CI. label May 22, 2020
@nebril
Copy link
Member Author

nebril commented May 22, 2020

test-runtime

@nebril
Copy link
Member Author

nebril commented May 22, 2020

test-net-next

@nebril
Copy link
Member Author

nebril commented May 22, 2020

test-4.19

@nebril
Copy link
Member Author

nebril commented May 22, 2020

test-4.9

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 36.887% when pulling db2b4a7 on pr/dont-delete-terminating-pods into df16d5d on master.

@nebril
Copy link
Member Author

nebril commented May 25, 2020

test-runtime

@nebril
Copy link
Member Author

nebril commented May 25, 2020

test-4.19

@nebril
Copy link
Member Author

nebril commented May 25, 2020

test-gke

@aanm aanm merged commit e86d61d into master May 25, 2020
1.8.0 automation moved this from In progress to Merged May 25, 2020
@aanm aanm deleted the pr/dont-delete-terminating-pods branch May 25, 2020 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants