Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Pass lockdebug tag to tests #11657

Merged
merged 1 commit into from May 25, 2020
Merged

Makefile: Pass lockdebug tag to tests #11657

merged 1 commit into from May 25, 2020

Conversation

christarazi
Copy link
Member

@christarazi christarazi commented May 22, 2020 •
edited

Previously, the lockdebug tag was only on the building of the binary.
This commit adds the ability to pass the tag to go test to debug
deadlocks in tests.

Example usage:

$ make RACE=1 LOCKDEBUG=1 unit-tests

@christarazi christarazi requested a review from a team as a code owner May 22, 2020 16:26
@christarazi christarazi added area/build Anything to do with the build, more general then area/CI area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact. labels May 22, 2020
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 May 22, 2020
@christarazi
Copy link
Member Author

Don't think this needs a full CI run, so I'll just let Travis do its thing, and that's probably enough.

@coveralls
Copy link

coveralls commented May 22, 2020 •
edited

Coverage Status

Coverage decreased (-0.02%) to 36.866% when pulling f5de10d on christarazi:pr/christarazi/add-lockdebug-tests into c42b879 on cilium:master.

@aanm
Copy link
Member

aanm commented May 25, 2020

test-runtime

@christarazi
Makefile: Pass lockdebug tag to tests
f5de10d 
Previously, the lockdebug tag was only on the building of the binary.
This commit adds the ability to pass the tag to `go test` to debug
deadlocks in tests.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi force-pushed the pr/christarazi/add-lockdebug-tests branch from 1f5b756 to f5de10d Compare May 25, 2020 21:55
@christarazi
Copy link
Member Author

christarazi commented May 25, 2020 •
edited

test-runtime

Edit: travis hit #11560

@christarazi christarazi merged commit dfe8ba1 into cilium:master May 25, 2020
1.8.0 automation moved this from In progress to Merged May 25, 2020
@christarazi christarazi deleted the pr/christarazi/add-lockdebug-tests branch May 26, 2020 19:16
@christarazi christarazi mentioned this pull request May 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianvernon ianvernon ianvernon approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
area/build Anything to do with the build, more general then area/CI area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@christarazi @coveralls @aanm @ianvernon @michi-covalent