ci/K8sHubble: Retry failed requests on hubble-relay #11708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of hubble-relay is intentionally not very aggressive when reconnecting to failed nodes. It will only try to reconnect once it receives a new request. In CI, this behavior causes flakes. The first request to hubble-relay may fail in case cilium-agent was not yet ready when hubble-relay was deployed. This commit introduces a retry mechanism for CI: We retry the request to hubble-relay after 5 seconds, this allows it to re-establish the connection to each node for subsequent requests. Fixes: #11707 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added
area/CI
|
test-me-please |
rolinh
approved these changes
May 27, 2020
aanm
approved these changes
May 27, 2020
nebril
approved these changes
May 27, 2020
|
Kernel 4.19 hit a known flake https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Kernel/1731/testReport/junit/Suite-k8s-1/17/K8sServicesTest_Checks_service_across_nodes_with_L7_policy_Tests_NodePort_with_L7_Policy/ Not restarting, since the failure is unrelated. |
gandro
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of hubble-relay is intentionally not very aggressive
when reconnecting to failed nodes. It will only try to reconnect once it
receives a new request.
In CI, this behavior causes flakes. The first request to hubble-relay
may fail in case cilium-agent was not yet ready when hubble-relay was
deployed (see referenced issue below for examples).
This PR introduces a retry mechanism for CI: We retry the
request to hubble-relay after 5 seconds, this allows it to re-establish
the connection to each node for subsequent requests.
Fixes: #11707