Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix gke cluster lock #11712

Merged
merged 1 commit into from May 27, 2020
Merged

ci: fix gke cluster lock #11712

merged 1 commit into from May 27, 2020

Conversation

nebril
Copy link
Member

@nebril nebril commented May 27, 2020

No description provided.

@nebril
ci: fix gke cluster lock
874ace3 
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril requested a review from a team as a code owner May 27, 2020 13:21
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 May 27, 2020
@nebril
Copy link
Member Author

nebril commented May 27, 2020

test-gke K8sDemos.*

@nebril nebril added the release-note/ci This PR makes changes to the CI. label May 27, 2020
@errordeveloper
Copy link
Contributor

Ah, looks like my fault - I find set -e/ set +e toggling very hard to keep track of (surely I'm not alone), I hope we will eradicate this anti-pattern soon enough!

errordeveloper
errordeveloper approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@errordeveloper errordeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@nebril
Copy link
Member Author

nebril commented May 27, 2020

GKE build passed, merging this, will let people know on Slack to rebase

@nebril nebril merged commit 60bffa4 into master May 27, 2020
1.8.0 automation moved this from In progress to Merged May 27, 2020
@nebril nebril deleted the pr/fix-gke-select-cluster branch May 27, 2020 13:49
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 36.918% when pulling 874ace3 on pr/fix-gke-select-cluster into 6e3cdc8 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errordeveloper errordeveloper errordeveloper approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nebril @errordeveloper @coveralls @qmonnet