New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connectivity-check: Do not perform hostport in standard check #11715
Conversation
Due to HostPort not being enabled by default, do not perform the check by default. Require the "connectivity-check-hostport.yaml" to be deployed. Fixes: #11563 Signed-off-by: Thomas Graf <thomas@cilium.io>
test-focus K8sConformance* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, maybe keep the note with a slight modification.
|
||
.. note:: | ||
|
||
Depending on the kernel version you are running on, the HostPort feature may |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like this note can still be useful with a slight modification so that people know there is a separate yaml file they can deploy to test this feature if it's enabled:
kubectl apply -f \ |SCM_WEB|\/examples/kubernetes/connectivity-check/connectivity-check-hostport.yaml
Due to HostPort not being enabled by default, do not perform the check
by default. Require the "connectivity-check-hostport.yaml" to be
deployed.
Fixes: #11563