doc: Fix require-ipv4-pod-cidr value for ENI and Azure mode #11725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgraf
added
the
area/documentation
|
Please set the appropriate release note label. |
1 similar comment
|
Please set the appropriate release note label. |
tgraf
added
the
release-note/misc
The helm chart was incorrectly setting require-ipv4-pod-cidr for ENI and Azure IPAM modes. The commit moves the ipam value into the config chart and adjusts all guides to set it to the correct value instead of setting it indirectly via a meta value. Fixes: 934053c ("install/kubernetes: enable Cilium-based podCIDR allocation by default") Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
force-pushed
the
pr/tgraf/fix-ipam-helm-regression
branch
from
66aa41d
to
16229a4
Compare
|
test-me-please |
michi-covalent
approved these changes
May 28, 2020
aanm
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helm chart was incorrectly setting require-ipv4-pod-cidr for ENI
and Azure IPAM modes.
The commit moves the ipam value into the config chart and adjusts all
guides to set it to the correct value instead of setting it indirectly
via a meta value.
Fixes: 934053c ("install/kubernetes: enable Cilium-based podCIDR allocation by default")