Run precheck make target in Travis CI #11740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
force-pushed
the
pr/tklauser/travis-prechecks
branch
from
81152e3
to
828fd31
Compare
pchaigno
reviewed
May 28, 2020
tklauser
force-pushed
the
pr/tklauser/travis-prechecks
branch
2 times, most recently
from
3bc5436
to
4ac4e01
Compare
michi-covalent
approved these changes
May 28, 2020
There's no reason to wait with running contrib/scripts/lock-check.sh and contrib/scripts/rand-check.sh until after the build (i.e. the postcheck target) as they are using only `grep` to check. Move them to the precheck target so these errors are caught earlier. Updates #11730 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
The CI_BUILD define is no longer needed since commit 9886f71 ("pkg/bpf: remove #define depending on CI_BUILD") Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
This will allow various issues before actually running the tests in our CI. Use `-j 2` since Travis CI usually runs on 2 cores and some parts of the build benefit from that. Updates #11730 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
force-pushed
the
pr/tklauser/travis-prechecks
branch
from
4ac4e01
to
0d6fdc0
Compare
|
I think this PR can be merged without running Jenkins tests as it only affects the Travis CI build/test, which passed. |
tklauser
added
the
ready-to-merge
|
@tklauser I think this PR broke Travis CI on aarch64: https://travis-ci.com/github/cilium/cilium/jobs/341409008. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits for details.
Updates #11730