Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor: Fix ipcache lookup debug msg #11745

Merged
merged 1 commit into from May 29, 2020

Conversation

pchaigno
Copy link
Member

The ipcache lookup debug messages state:

Failed to map daddr

and

Successfully mapped daddr

but they aren't necessarily specific to the destination IP address.

The ipcache lookup debug messages state:

    Failed to map daddr

and

    Successfully mapped daddr

but the ipcache lookups aren't necessarily specific to the *destination*
IP address.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. release-note/misc This PR makes changes that have no direct user impact. labels May 28, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 May 28, 2020
@pchaigno
Copy link
Member Author

test-me-please

@pchaigno pchaigno marked this pull request as ready for review May 28, 2020 17:57
@pchaigno pchaigno requested a review from a team May 28, 2020 17:57
@pchaigno pchaigno requested a review from a team as a code owner May 28, 2020 17:57
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bugged me for a while, but I never got around to sending the patch. Thanks!

@pchaigno
Copy link
Member Author

retest-net-next

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 28, 2020
@aanm aanm merged commit 33cb7a5 into master May 29, 2020
1.8.0 automation moved this from In progress to Merged May 29, 2020
@aanm aanm deleted the pr/pchaigno/fix-ipcache-lookup-debug-msg branch May 29, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

3 participants