Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: parallelize log gathering #11748

Merged
merged 1 commit into from May 29, 2020
Merged

test: parallelize log gathering #11748

merged 1 commit into from May 29, 2020

Conversation

nebril
Copy link
Member

@nebril nebril commented May 28, 2020

We are running multiple kubectl commands to gather logs. This change
makes the gathering commands run in parallel.

@nebril nebril requested a review from a team as a code owner May 28, 2020 13:30
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 May 28, 2020
@nebril nebril added this to In Progress (Cilium) in CI Force via automation May 28, 2020
@nebril nebril added the release-note/ci This PR makes changes to the CI. label May 28, 2020
@nebril
Copy link
Member Author

nebril commented May 28, 2020

test-4.9

@nebril
Copy link
Member Author

nebril commented May 28, 2020

test-runtime

@nebril
Copy link
Member Author

nebril commented May 28, 2020

test-4.19

@nebril
Copy link
Member Author

nebril commented May 28, 2020

test-net-next

We are running multiple kubectl commands to gather logs. This change
makes the gathering commands run in parallel.

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril force-pushed the pr/parallelize-log-gathering branch from 4c5a74b to d064512 Compare May 29, 2020 05:38
@coveralls
Copy link

coveralls commented May 29, 2020

Coverage Status

Coverage increased (+0.01%) to 36.886% when pulling 67d3875bf270c91f97afc6cd1b85acc46050eb1b on pr/parallelize-log-gathering into 1439b27 on master.

@maintainer-s-little-helper
Copy link

Commit 67d3875bf270c91f97afc6cd1b85acc46050eb1b does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 29, 2020
@nebril
Copy link
Member Author

nebril commented May 29, 2020

Added a deliberate test failure to make a sanity check on generated logs

@nebril
Copy link
Member Author

nebril commented May 29, 2020

test-focus K8sServicesTest

@nebril
Copy link
Member Author

nebril commented May 29, 2020

test archives look good: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated-Focus/204/#showFailuresLink , removing the failing test commit and getting this merged

@nebril nebril force-pushed the pr/parallelize-log-gathering branch from 67d3875 to d064512 Compare May 29, 2020 09:26
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 29, 2020
@nebril
Copy link
Member Author

nebril commented May 29, 2020

test-4.9

@aanm aanm merged commit 9ea244f into master May 29, 2020
1.8.0 automation moved this from In progress to Merged May 29, 2020
CI Force automation moved this from In Progress (Cilium) to Fixed / Done May 29, 2020
@aanm aanm deleted the pr/parallelize-log-gathering branch May 29, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.8.0
  
Merged
CI Force
  
Fixed / Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants