Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Wait for IPCache entries in testSessionAffinity #11771

Merged
merged 1 commit into from May 29, 2020

Conversation

brb
Copy link
Member

@brb brb commented May 29, 2020

We need to wait for an IPCache entry of the restarted pod. Otherwise, a next testSessionAffinity test invokation (with fromOutside = true) might fail, as it could take up to 10s for the entry to appear. See [1] for more details.

This is a temporary fix to get rid of the session affinity flakes.

[1]: #11751

Fix #11698

We need to wait for an IPCache entry of the restarted pod. Otherwise, a
next testSessionAffinity test (with fromOutside = true) might fail, as
it could take up to 10s for the entry to appear. See [1] for more
details.

This is a temporary fix to get rid of the session affinity flakes.

[1]: #11751

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added pending-review area/CI Continuous Integration testing issue or flake labels May 29, 2020
@brb brb requested a review from a team as a code owner May 29, 2020 10:06
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

3 similar comments
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@brb
Copy link
Member Author

brb commented May 29, 2020

retest-net-next

@brb brb added this to In Progress (Cilium) in CI Force via automation May 29, 2020
@tklauser tklauser added the release-note/ci This PR makes changes to the CI. label May 29, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 36.85% when pulling b04ec74 on pr/brb/fix-session-affinity-flake into 05daeef on master.

@brb
Copy link
Member Author

brb commented May 29, 2020

CI provisioning timeout.

@brb
Copy link
Member Author

brb commented May 29, 2020

retest-net-next

@brb
Copy link
Member Author

brb commented May 29, 2020

CI net-next hit #11741 flake. We can merge this PR.

@aanm aanm merged commit 9accb13 into master May 29, 2020
1.8.0 automation moved this from In progress to Merged May 29, 2020
CI Force automation moved this from In Progress (Cilium) to Fixed / Done May 29, 2020
@aanm aanm deleted the pr/brb/fix-session-affinity-flake branch May 29, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.8.0
  
Merged
CI Force
  
Fixed / Done
6 participants