docker: add hubble CLI binary to the base cilium image #11784
Conversation
This increases the size of the cilium image by ~12MB (from 408MB to 420MB) but on the other end provides a tailor-made tool to troubleshoot network issues. It is expected that once Hubble Relay is GA, having the hubble CLI binary as part of the base image will no longer be necessary. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
added
kind/feature
|
Note: this is a draft as it is expected to fail until Hubble v0.6.0 is tagged and the image available on quay.io. |
There was a problem hiding this comment.
Even if we're adding 12MB, the v1.8.0 images are probably smaller than the v1.7.x images (AFAICT ~40% smaller) and we're gaining a bunch of functionality here. My concern would be more about locking a particular version of the CLI into this tree but honestly I think the hubble CLI is likely mature enough at this point that it won't be a problem.
(Btw I compared the image sizes you mentioned against https://hub.docker.com/repository/registry-1.docker.io/cilium/cilium/tags?page=1 and I'm guessing you're quoting uncompressed sizes, so the actual distribution size with the added binary is likely even smaller.)
This is correct; I should have made that clear. |
|
|
|
Do we want to point to the latest 0.6.X branch with patch fixes, or pin to 0.6.0 specifically? I'm thinking latest 0.6 is probably the best course of action so we can commit bug fixes and such without the need for a patch cilium release |
personally i prefer to pin the image to a specific tag but i can go either way. @rolinh ? |
The flip side is if there's no explicit change in the codebase then any regression leaks in then simply compiling a new Cilium image will render in the broken version. That's hard to track because the build is dependent on the time that you generate the image (including any subsequent fix). |
I'd prefer to pin a specific version as well. Yes, this means an extra step when we tag a new hubble CLI bugfix release but on the other end, the hubble CLI update commit will also be mentioned in cilium's release notes. Note that in both cases, a new cilium image has to be tagged for the newer hubble CLI to be picked up anyway. |
|
test-me-please |
|
retest-4.19 |
|
retest-4.9 |
gandro
added
the
ready-to-merge
This increases the size of the cilium image by ~12MB (from 408MB to
420MB) but on the other end provides a tailor-made tool to troubleshoot
network issues.
It is expected that once Hubble Relay is GA, having the hubble CLI
binary as part of the base image will no longer be necessary.