Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable host firewall in kube-proxy-free CI #11795

Merged
merged 4 commits into from Jun 4, 2020

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented May 31, 2020

This first commit adds a new Helm option to enable the host firewall, which then allows the second commit to enable it in our kube-proxy-free CI builds (K8s 1.11 Linux net-next). The third and last commits fix two issues found this way: (1) a missing case for ARP resolution on from-{netdev,host} paths, and (2) packet drops when tunneling is enabled. I'm not sure how I missed the second before since I had already ran the CI build (although not with the Helm option).

Enabling host firewall on 4.19 is currently blocked by #10567.

Updates: #11799
Fixes: #11507

Fix tunneling and ARP resolution when host firewall is enabled.

@pchaigno pchaigno added the release-note/misc This PR makes changes that have no direct user impact. label May 31, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 May 31, 2020
@pchaigno
Copy link
Member Author

retest-net-next

@coveralls
Copy link

coveralls commented May 31, 2020

Coverage Status

Coverage decreased (-0.01%) to 36.901% when pulling 4bd0540 on pr/pchaigno/enable-host-firewall-in-ci into 5b12097 on master.

Signed-off-by: Paul Chaignon <paul@cilium.io>
This commit enables the enforcement of host policies in the datapath for
our kube-proxy-free CI builds. Since no host policies are loaded, it
defaults to allow all on ingress and egress.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the pr/pchaigno/enable-host-firewall-in-ci branch from 2fe2b79 to 6da0fe3 Compare June 3, 2020 17:17
Fixes: 88bf291 ("bpf: Enforce host policies for IPv4")
Signed-off-by: Paul Chaignon <paul@cilium.io>
Fixes: 88bf291 ("bpf: Enforce host policies for IPv4")
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the pr/pchaigno/enable-host-firewall-in-ci branch from 6da0fe3 to 4bd0540 Compare June 3, 2020 17:21
@pchaigno pchaigno added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. needs-backport/1.8 labels Jun 3, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 3, 2020
@pchaigno
Copy link
Member Author

pchaigno commented Jun 3, 2020

test-me-please

@pchaigno pchaigno added release-note/bug This PR fixes an issue in a previous release of Cilium. and removed release-note/misc This PR makes changes that have no direct user impact. labels Jun 3, 2020
@pchaigno pchaigno changed the title Enable host firewall in CI Enable host firewall in kube-proxy-free CI Jun 3, 2020
@pchaigno pchaigno marked this pull request as ready for review June 3, 2020 20:36
@pchaigno pchaigno requested a review from a team June 3, 2020 20:36
@pchaigno pchaigno requested review from a team as code owners June 3, 2020 20:36
@pchaigno pchaigno requested a review from a team June 3, 2020 20:36
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, otherwise LGTM.

bpf/bpf_host.c Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 4, 2020
@tgraf tgraf merged commit 1e73a79 into master Jun 4, 2020
1.8.0 automation moved this from In progress to Merged Jun 4, 2020
@tgraf tgraf deleted the pr/pchaigno/enable-host-firewall-in-ci branch June 4, 2020 09:40
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 4, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 5, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 5, 2020
@pchaigno pchaigno added the area/host-firewall Impacts the host firewall or the host endpoint. label Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/host-firewall Impacts the host firewall or the host endpoint. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.8.0
  
Merged
1.8.0
Backport done to v1.8
Development

Successfully merging this pull request may close these issues.

None yet

8 participants