New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable host firewall in kube-proxy-free CI #11795
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
May 31, 2020
retest-net-next |
34 tasks
Signed-off-by: Paul Chaignon <paul@cilium.io>
This commit enables the enforcement of host policies in the datapath for our kube-proxy-free CI builds. Since no host policies are loaded, it defaults to allow all on ingress and egress. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/enable-host-firewall-in-ci
branch
from
June 3, 2020 17:17
2fe2b79
to
6da0fe3
Compare
pchaigno
force-pushed
the
pr/pchaigno/enable-host-firewall-in-ci
branch
from
June 3, 2020 17:21
6da0fe3
to
4bd0540
Compare
pchaigno
added
sig/datapath
Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
needs-backport/1.8
labels
Jun 3, 2020
test-me-please |
pchaigno
added
release-note/bug
This PR fixes an issue in a previous release of Cilium.
and removed
release-note/misc
This PR makes changes that have no direct user impact.
labels
Jun 3, 2020
pchaigno
changed the title
Enable host firewall in CI
Enable host firewall in kube-proxy-free CI
Jun 3, 2020
joestringer
requested changes
Jun 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, otherwise LGTM.
christarazi
approved these changes
Jun 4, 2020
joestringer
approved these changes
Jun 4, 2020
brb
approved these changes
Jun 4, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Jun 4, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
Jun 4, 2020
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
Jun 5, 2020
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
Jun 5, 2020
pchaigno
added
the
area/host-firewall
Impacts the host firewall or the host endpoint.
label
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/host-firewall
Impacts the host firewall or the host endpoint.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
sig/datapath
Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This first commit adds a new Helm option to enable the host firewall, which then allows the second commit to enable it in our kube-proxy-free CI builds (K8s 1.11 Linux net-next). The third and last commits fix two issues found this way: (1) a missing case for ARP resolution on
from-{netdev,host}
paths, and (2) packet drops when tunneling is enabled. I'm not sure how I missed the second before since I had already ran the CI build (although not with the Helm option).Enabling host firewall on 4.19 is currently blocked by #10567.
Updates: #11799
Fixes: #11507