Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: re-design cilium docs theme #11803

Merged
merged 1 commit into from Jun 10, 2020
Merged

Conversation

genbit
Copy link
Contributor

@genbit genbit commented Jun 1, 2020

Signed-off-by: Sergey Generalov sergey@genbit.ru

@genbit genbit requested a review from a team as a code owner June 1, 2020 21:40
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@coveralls
Copy link

coveralls commented Jun 1, 2020

Coverage Status

Coverage increased (+0.01%) to 37.039% when pulling a35cc1b on genbit/docs-theme-redesign into 74c6d25 on master.

@michi-covalent michi-covalent added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. needs-backport/1.8 release-note/misc This PR makes changes that have no direct user impact. labels Jun 1, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 1, 2020
@michi-covalent
Copy link
Contributor

thanks @genbit it looks great overall. maybe we should put the cilium logo on the top left corner? it looks a bit empty right now.

Screen Shot 2020-06-01 at 3 28 25 PM

@michi-covalent
Copy link
Contributor

@genbit it's getting better but not quite there yet :)

Screen Shot 2020-06-01 at 3 36 25 PM

@michi-covalent michi-covalent marked this pull request as draft June 2, 2020 04:29
@genbit genbit force-pushed the genbit/docs-theme-redesign branch from 92a8d3f to de925ac Compare June 2, 2020 19:51
@maintainer-s-little-helper
Copy link

Commit 5c1659c7621e439d83e644dbee4addd8cadd5a4a does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 2, 2020
@genbit genbit force-pushed the genbit/docs-theme-redesign branch from 5c1659c to 4f494a6 Compare June 2, 2020 20:38
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 2, 2020
@genbit genbit force-pushed the genbit/docs-theme-redesign branch 6 times, most recently from f8c6cb1 to 8424310 Compare June 2, 2020 21:50
@genbit genbit changed the title [WIP] docs: introduce white cilium docs version docs: introduce white cilium docs version Jun 2, 2020
@genbit genbit marked this pull request as ready for review June 2, 2020 22:28
@maintainer-s-little-helper
Copy link

Commit e0a42dec079f4f4357cf227b00f3820879b46f99 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 2, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 11, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 11, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Needs backport from master in 1.8.0 Jun 11, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 12, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 12, 2020
@joestringer
Copy link
Member

1.8 backport is being handled in #12032

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport pending to v1.7 in 1.7.5 Jun 12, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport pending to v1.6 in 1.6.10 Jun 12, 2020
@joestringer joestringer removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jun 12, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 12, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.5 Jul 1, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.5 Jul 1, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.6 to Backport done to v1.6 in 1.6.10 Jul 1, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.6 to Backport done to v1.6 in 1.6.10 Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.6.10
Backport done to v1.6
1.7.5
Backport done to v1.7
1.8.0
  
Merged
1.8.0
Backport done to v1.8
Development

Successfully merging this pull request may close these issues.

None yet

6 participants