bpf: Fix race when accessing m.fd #11812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open() writes to m.fd and thus must hold m.lock while doing so. Require m.lock to be held for writing. This also means that we can remove m.openLock. This simplifies the overall fix as the question of order when acquiring m.lock and m.openLock does not come up. Fixes: #10990 Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
added
kind/bug
|
test-me-please |
tklauser
reviewed
Jun 2, 2020
tklauser
approved these changes
Jun 2, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open() writes to m.fd and thus must hold m.lock while doing so. Require
m.lock to be held for writing. This also means that we can remove
m.openLock. This simplifies the overall fix as the question of order
when acquiring m.lock and m.openLock does not come up.
Fixes: #10990