Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update backport commands for jenkins builds #11860

Merged
merged 1 commit into from Jun 3, 2020

Conversation

nebril
Copy link
Member

@nebril nebril commented Jun 3, 2020

No description provided.

@nebril nebril requested review from a team as code owners June 3, 2020 12:36
@maintainer-s-little-helper
Copy link

Commit 665b72a930b09a10c2f5047189dd5b127f2ac127 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 3, 2020
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@nebril
Copy link
Member Author

nebril commented Jun 3, 2020

test-backport-1.6

@nebril
Copy link
Member Author

nebril commented Jun 3, 2020

test-backport-1.7

@nebril
Copy link
Member Author

nebril commented Jun 3, 2020

test-backport-1.8

@nebril
Copy link
Member Author

nebril commented Jun 3, 2020

seems like new commands are working as intended

@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 3, 2020
@nebril nebril added the release-note/ci This PR makes changes to the CI. label Jun 3, 2020
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should we change it in Documentation/contributing/testing/ci.rst (line 239ff):

For Backport PRs, the phrase ``never-tell-me-the-odds`` should be used to
trigger all of the above jobs which are marked as required to validate changes
to existing releases.

was well? Sorry, cannot link to the raw file line directly 😕

@coveralls
Copy link

coveralls commented Jun 3, 2020

Coverage Status

Coverage increased (+0.01%) to 36.926% when pulling 4e226e8 on pr/doc-test-backport into bdf98cb on master.

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril
Copy link
Member Author

nebril commented Jun 3, 2020

@tklauser thanks, fixed that too!

Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added change in ci.rst also LGTM, thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 3, 2020
@aanm aanm added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 3, 2020
@joestringer joestringer merged commit 78d99a5 into master Jun 3, 2020
1.8.0 automation moved this from In progress to Merged Jun 3, 2020
@joestringer joestringer deleted the pr/doc-test-backport branch June 3, 2020 18:45
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 4, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.8 in 1.8.0 Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants