Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Do not set tty for preloaded VM #11877

Merged
merged 1 commit into from Jun 4, 2020
Merged

test: Do not set tty for preloaded VM #11877

merged 1 commit into from Jun 4, 2020

Conversation

jrajahalme
Copy link
Member

Setting tty sock for preloaded VM can interfere with the actual VM
being started later.

Signed-off-by: Jarno Rajahalme jarno@covalent.io

@jrajahalme
test: Do not set tty for preloaded VM
d218318 
Setting tty sock for preloaded VM can interfere with the actual VM
being started later.

Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme added kind/bug/CI This is a bug in the testing code. area/CI Continuous Integration testing issue or flake release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Jun 3, 2020
@jrajahalme jrajahalme requested a review from a team as a code owner June 3, 2020 21:12
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Jun 3, 2020
@jrajahalme
Copy link
Member Author

test-me-please

@jrajahalme
Copy link
Member Author

Note that VM preloading is only used by test/vagrant-local-start.sh, so this should not affect the CI at all.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0004%) to 36.932% when pulling d218318 on pr/jrajahalme/test-no-tty-for-preloaded-vm into 8ba1f84 on master.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 4, 2020
@nebril nebril merged commit 4e3283c into master Jun 4, 2020
1.8.0 automation moved this from In progress to Merged Jun 4, 2020
@nebril nebril deleted the pr/jrajahalme/test-no-tty-for-preloaded-vm branch June 4, 2020 13:08
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 5, 2020
@tklauser tklauser mentioned this pull request Jun 5, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 5, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 6, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.8.0
  
Merged
1.8.0
Backport done to v1.8
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jrajahalme @coveralls @nebril @aanm @tklauser @joestringer