Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: k3s command missing sh - #11878

Merged
merged 1 commit into from Jun 4, 2020
Merged

docs: k3s command missing sh - #11878

merged 1 commit into from Jun 4, 2020

Conversation

glibsm
Copy link
Member

@glibsm glibsm commented Jun 3, 2020

Spent a long time trying to figure out what went wrong, turns out the command to join nodes was just missing sh - to actually run it :|

Signed-off-by: Glib Smaga code@gsmaga.com

Signed-off-by: Glib Smaga <code@gsmaga.com>
@glibsm glibsm requested a review from a team as a code owner June 3, 2020 21:16
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Jun 3, 2020
@glibsm glibsm added the release-note/misc This PR makes changes that have no direct user impact. label Jun 3, 2020
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 36.911% when pulling a1854eb on pr/glibsm/add-sh into 8ba1f84 on master.

@aanm aanm added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 4, 2020
@aanm aanm merged commit 673c3f5 into master Jun 4, 2020
1.8.0 automation moved this from In progress to Merged Jun 4, 2020
@aanm aanm deleted the pr/glibsm/add-sh branch June 4, 2020 12:26
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 5, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 5, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
1.8.0
Backport done to v1.8
Development

Successfully merging this pull request may close these issues.

None yet

6 participants