Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/scalability: set right ipam option #11890

Merged
merged 1 commit into from Jun 5, 2020
Merged

Conversation

aanm
Copy link
Member

@aanm aanm commented Jun 4, 2020

The ipam option was moved from global to the ConfigMap so the
scalability documentation needs to be updated.

Fixes: c1a0025 ("doc: Fix require-ipv4-pod-cidr value for ENI and Azure mode")
Signed-off-by: André Martins andre@cilium.io

@aanm aanm added priority/release-blocker area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. labels Jun 4, 2020
@aanm aanm requested a review from a team as a code owner June 4, 2020 12:22
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

3 similar comments
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 4, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Jun 4, 2020
The ipam option was moved from global to the ConfigMap so the
scalability documentation needs to be updated.

Fixes: c1a0025 ("doc: Fix require-ipv4-pod-cidr value for ENI and Azure mode")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Jun 4, 2020
@aanm aanm force-pushed the pr/fix-scalability-docs branch from 0123036 to bfeb905 Compare June 4, 2020 12:24
@coveralls
Copy link

coveralls commented Jun 4, 2020

Coverage Status

Coverage decreased (-0.002%) to 36.932% when pulling bfeb905 on pr/fix-scalability-docs into 7f617ed on master.

@aanm aanm changed the title docs/scalability: add set right ipam option docs/scalability: set right ipam option Jun 4, 2020
@aanm aanm merged commit 05f8d34 into master Jun 5, 2020
1.8.0 automation moved this from In progress to Merged Jun 5, 2020
@aanm aanm deleted the pr/fix-scalability-docs branch June 5, 2020 07:35
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 5, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 5, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 6, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
Backport done to v1.8
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants