New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/scalability: set right ipam option #11890
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
priority/release-blocker
area/documentation
Impacts the documentation, including textual changes, sphinx, or other doc generation code.
labels
Jun 4, 2020
Please set the appropriate release note label. |
3 similar comments
Please set the appropriate release note label. |
Please set the appropriate release note label. |
Please set the appropriate release note label. |
The ipam option was moved from global to the ConfigMap so the scalability documentation needs to be updated. Fixes: c1a0025 ("doc: Fix require-ipv4-pod-cidr value for ENI and Azure mode") Signed-off-by: André Martins <andre@cilium.io>
aanm
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
Jun 4, 2020
aanm
force-pushed
the
pr/fix-scalability-docs
branch
from
June 4, 2020 12:24
0123036
to
bfeb905
Compare
aanm
changed the title
docs/scalability: add set right ipam option
docs/scalability: set right ipam option
Jun 4, 2020
michi-covalent
approved these changes
Jun 4, 2020
tgraf
approved these changes
Jun 4, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
Jun 5, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
Jun 5, 2020
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
Jun 6, 2020
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Impacts the documentation, including textual changes, sphinx, or other doc generation code.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ipam option was moved from global to the ConfigMap so the
scalability documentation needs to be updated.
Fixes: c1a0025 ("doc: Fix require-ipv4-pod-cidr value for ENI and Azure mode")
Signed-off-by: André Martins andre@cilium.io