1.8 Documentation updates #11892
Merged
1.8 Documentation updates #11892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgraf
added
priority/release-blocker
area/documentation
joestringer
requested changes
Jun 4, 2020
There was a problem hiding this comment.
LGTM, one minor comment below.
Would be nice to get a second view from someone like @seanmwinn / @jedsalazar .
jedsalazar
reviewed
Jun 4, 2020
christarazi
reviewed
Jun 4, 2020
There was a problem hiding this comment.
LGTM, when I looked at #11868 yesterday, I noticed that we have two of the same Helm deploy instructions for AWS / EKS / ENI. See EKS guide and ENI guide. It'd be nice if we can consolidate these two Helm instruction sections into one, by putting the shared info into a separate file and referencing it in the two sections. This would help avoid an inconsistency cropping up like the above issue.
brb
reviewed
Jun 4, 2020
| -------------------- | ||
|
|
||
| eBPF-based | ||
| The eBPF-based implementation is the most efficient |
There was a problem hiding this comment.
Once this PR is emerged, I will extend this section to add more info about device selection.
tklauser
reviewed
Jun 5, 2020
Signed-off-by: Thomas Graf <thomas@cilium.io>
There is nothing nulti-node specific about this section. Rename it to just networking. Signed-off-by: Thomas Graf <thomas@cilium.io>
Fixes: #11369 Signed-off-by: Thomas Graf <thomas@cilium.io>
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11868
Fixes: #11369