pkg/k8s: delete toCIDRSets for more than 2 endpoints #11901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
kind/bug
aanm
force-pushed
the
pr/avoid-duplicate-cidrsets
branch
from
b07f933
to
a4af651
Compare
joestringer
approved these changes
Jun 4, 2020
jrajahalme
reviewed
Jun 4, 2020
In case a toServices selected a service that contained more than 1 endpoint, the generated rules could never be deleted. This can easily be reproducible by adding one more endpoint to the unit test of the deleteToCidrFromEndpoint function. Fixes: bae09f7 ("Move ToCIDR gen logic to k8s package") Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/avoid-duplicate-cidrsets
branch
from
a4af651
to
89c03d4
Compare
jrajahalme
approved these changes
Jun 4, 2020
|
test-me-please |
|
v1.6 backport for reference: #11900 |
|
The lone CI fail is a known flake (#11895) |
maintainer-s-little-helper
bot
moved this from Backport pending to v1.6
to Backport done to v1.6
in 1.6.9
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a toServices selected a service that contained more than 1
endpoint, the generated rules could never be deleted. This can easily be
reproducible by adding one more endpoint to the unit test of the
deleteToCidrFromEndpoint function.
Fixes: bae09f7 ("Move ToCIDR gen logic to k8s package")
Signed-off-by: André Martins andre@cilium.io
The PR for the v1.6 branch is made separately since the code is slightly different: #11900