helm: Generate experimental-install.yaml #11907

michi-covalent · 2020-06-05T00:17:00Z

Generate experimental-install.yaml in which we can enable experimental/beta
features without changing default values in the Helm chart. This makes
it easier for users to play around with bleeding edge features with a
simple kubectl apply.

Ref #11902

Signed-off-by: Michi Mutsuzaki michi@isovalent.com

coveralls · 2020-06-05T00:50:24Z

Coverage increased (+0.05%) to 36.993% when pulling bbdd87a on pr/michi/ultimate into 02b43fc on master.

aanm · 2020-06-05T08:02:54Z

install/kubernetes/Makefile

@@ -16,12 +17,21 @@ DEV_VERSION_REGEX := '[0-9]\+\.[0-9]\+\.[0-9]\+-dev'
 CILIUM_CHART_REGEX := '\([vV]ersion:\) '$(VERSION_REGEX)
 CILIUM_TAG_REGEX := '\(tag:\) \(v'$(VERSION_REGEX)'\|latest\)'
 CILIUM_PULLPOLICY_REGEX := '\(pullPolicy:\) .*'
+ULTIMATE_OPTIONS := \
+    --set global.hubble.enabled=true \
+    --set global.hubble.listenAddress=":4244" \


Should we enable this by default without any warning to the user? (I know there's a warning in the logs but that would be it)

@aanm Are you saying that we should enable these options by default for all cilium installs or asking whether we should warn users when these settings are enabled?

@aanm Are you saying that we should enable these options by default for all cilium installs or asking whether we should warn users when these settings are enabled?

warn users when these settings are enabled since this might be unnoticed.

@aanm @rolinh i was thinking of simply putting a warning in the cilium doc whenever we mention kubectl apply -f experimental-install.yaml. i'd be happy to add warnings in other place if we already have some sort of convention to warn users about experimental features with security implications.

@aanm How would you suggest the warning should be delivered to users? In cilium status? IMO if it is not possible for the user to use the experimental options without explicitly invoking experimental-install.yaml on the command line warnings in the docs that document such use should be enough.

Note that we can generate custom text in the Helm NOTES output depending on specific helm options.

this is how the warning is worded right now: https://github.com/cilium/cilium/pull/11882/files#diff-0806f700bf4c3d27724e99235d5f13a8R47

@joestringer yeah i think it makes sense to add a warning in NOTES.txt if global.hubble.listenAddress is set. i will open a separate PR for that since it's not directly related to experimental-install.yaml.

rolinh · 2020-06-05T08:44:40Z

install/kubernetes/Makefile

@@ -16,12 +17,21 @@ DEV_VERSION_REGEX := '[0-9]\+\.[0-9]\+\.[0-9]\+-dev'
 CILIUM_CHART_REGEX := '\([vV]ersion:\) '$(VERSION_REGEX)
 CILIUM_TAG_REGEX := '\(tag:\) \(v'$(VERSION_REGEX)'\|latest\)'
 CILIUM_PULLPOLICY_REGEX := '\(pullPolicy:\) .*'
+ULTIMATE_OPTIONS := \
+    --set global.hubble.enabled=true \
+    --set global.hubble.listenAddress=":4244" \


@aanm Are you saying that we should enable these options by default for all cilium installs or asking whether we should warn users when these settings are enabled?

install/kubernetes/ultimate-install.yaml

errordeveloper · 2020-06-05T12:52:24Z

@michi-covalent I am not very clear on why it's 'ultimate', from the description it sounds like 'experimental' would be more appropriate... Could you explain the intention please?

michi-covalent · 2020-06-05T22:47:41Z

@michi-covalent I am not very clear on why it's 'ultimate', from the description it sounds like 'experimental' would be more appropriate... Could you explain the intention please?

i like experimental-install.yaml better. will rename

Ref: #11907 (comment) Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

Generate experimental-install.yaml in which we can enable experimental features without changing default values in the Helm chart. This makes it easier for users to play around with bleeding edge features with a simple `kubectl apply`. Ref #11902 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent · 2020-06-08T23:58:19Z

test-me-please

aanm

No test

aanm

test

aanm

t

aanm

t

Ref: #11907 (comment) Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

[ upstream commit a67554d ] Ref: #11907 (comment) Signed-off-by: Michi Mutsuzaki <michi@isovalent.com> Signed-off-by: André Martins <andre@cilium.io>

michi-covalent added release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay area/helm Impacts helm charts and user deployment experience needs-backport/1.8 labels Jun 5, 2020

michi-covalent requested review from a team as code owners June 5, 2020 00:17

michi-covalent requested a review from a team June 5, 2020 00:17

maintainer-s-little-helper bot added this to In progress in 1.8.0 Jun 5, 2020

maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 5, 2020

michi-covalent force-pushed the pr/michi/ultimate branch from 4528395 to 3aab704 Compare June 5, 2020 00:23

michi-covalent mentioned this pull request Jun 5, 2020

doc: Update the Hubble section of getting started guides #11882

Merged

michi-covalent force-pushed the pr/michi/ultimate branch from 3aab704 to 0d60db0 Compare June 5, 2020 00:51

aanm previously requested changes Jun 5, 2020

View reviewed changes

rolinh reviewed Jun 5, 2020

View reviewed changes

nebril approved these changes Jun 5, 2020

View reviewed changes

michi-covalent added 2 commits June 5, 2020 15:53

helm: Fix the name/namespace order

d044c7c

Ref: #11907 (comment) Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent force-pushed the pr/michi/ultimate branch from 0d60db0 to bbdd87a Compare June 5, 2020 22:58

michi-covalent changed the title ~~helm: Generate ultimate-install.yaml~~ helm: Generate experimental-install.yaml Jun 6, 2020

jrajahalme approved these changes Jun 8, 2020

View reviewed changes

maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 9, 2020

aanm removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 9, 2020

maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 9, 2020

aanm removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 9, 2020

maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 9, 2020

aanm requested changes Jun 9, 2020

View reviewed changes

aanm added the area/helm Impacts helm charts and user deployment experience label Jun 9, 2020

maintainer-s-little-helper bot removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 9, 2020

aanm approved these changes Jun 9, 2020

View reviewed changes

aanm requested changes Jun 9, 2020

View reviewed changes

aanm approved these changes Jun 9, 2020

View reviewed changes

maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jun 9, 2020

rolinh approved these changes Jun 9, 2020

View reviewed changes

aanm requested changes Jun 9, 2020

View reviewed changes

aanm approved these changes Jun 9, 2020

View reviewed changes

maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 9, 2020

aanm approved these changes Jun 9, 2020

View reviewed changes

aanm merged commit ed65830 into master Jun 9, 2020

1.8.0 automation moved this from In progress to Merged Jun 9, 2020

aanm deleted the pr/michi/ultimate branch June 9, 2020 12:33

aanm pushed a commit that referenced this pull request Jun 9, 2020

helm: Fix the name/namespace order

a67554d

Ref: #11907 (comment) Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

aanm added backport-pending/1.8 and removed needs-backport/1.8 labels Jun 9, 2020

maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 9, 2020

maintainer-s-little-helper bot removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 9, 2020

aanm pushed a commit that referenced this pull request Jun 9, 2020

helm: Fix the name/namespace order

f79eb94

[ upstream commit a67554d ] Ref: #11907 (comment) Signed-off-by: Michi Mutsuzaki <michi@isovalent.com> Signed-off-by: André Martins <andre@cilium.io>

aanm mentioned this pull request Jun 9, 2020

v1.8 backports 2020-06-09 #11984

Merged

aanm pushed a commit that referenced this pull request Jun 10, 2020

helm: Fix the name/namespace order

0baa7d6

[ upstream commit a67554d ] Ref: #11907 (comment) Signed-off-by: Michi Mutsuzaki <michi@isovalent.com> Signed-off-by: André Martins <andre@cilium.io>

aanm added backport-done/1.8 and removed backport-pending/1.8 labels Jun 12, 2020

maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 12, 2020

maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jun 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

helm: Generate experimental-install.yaml #11907

helm: Generate experimental-install.yaml #11907

michi-covalent commented Jun 5, 2020 •

edited

coveralls commented Jun 5, 2020 •

edited

aanm Jun 5, 2020

rolinh Jun 5, 2020

aanm Jun 5, 2020

michi-covalent Jun 5, 2020

jrajahalme Jun 8, 2020

joestringer Jun 9, 2020

michi-covalent Jun 9, 2020

michi-covalent Jun 9, 2020

rolinh Jun 5, 2020

errordeveloper commented Jun 5, 2020 •

edited

michi-covalent commented Jun 5, 2020

michi-covalent commented Jun 8, 2020

aanm left a comment

aanm left a comment

aanm left a comment

aanm left a comment

helm: Generate experimental-install.yaml #11907

helm: Generate experimental-install.yaml #11907

Conversation

michi-covalent commented Jun 5, 2020 • edited

coveralls commented Jun 5, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

errordeveloper commented Jun 5, 2020 • edited

michi-covalent commented Jun 5, 2020

michi-covalent commented Jun 8, 2020

aanm left a comment

Choose a reason for hiding this comment

aanm left a comment

Choose a reason for hiding this comment

aanm left a comment

Choose a reason for hiding this comment

aanm left a comment

Choose a reason for hiding this comment

michi-covalent commented Jun 5, 2020 •

edited

coveralls commented Jun 5, 2020 •

edited

errordeveloper commented Jun 5, 2020 •

edited