Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cilium: rename --node-port-acceleration=none to =disabled #11925

Merged
merged 1 commit into from Jun 6, 2020

Conversation

borkmann
Copy link
Member

@borkmann borkmann commented Jun 5, 2020

Be more consistent and rename to "disable" since this is common for
various other flags already.

Signed-off-by: Daniel Borkmann daniel@iogearbox.net

@borkmann borkmann added pending-review area/daemon Impacts operation of the Cilium daemon. release-note/misc This PR makes changes that have no direct user impact. labels Jun 5, 2020
@borkmann borkmann requested review from brb and a team June 5, 2020 15:26
@borkmann borkmann requested review from a team as code owners June 5, 2020 15:26
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Jun 5, 2020
@borkmann
Copy link
Member Author

borkmann commented Jun 5, 2020

test-me-please

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 5, 2020
@coveralls
Copy link

coveralls commented Jun 5, 2020

Coverage Status

Coverage increased (+0.05%) to 36.993% when pulling 93247b3 on pr/rename-disabled into 02b43fc on master.

daemon/cmd/daemon_main.go Outdated Show resolved Hide resolved
Be more consistent and rename to "disable" since this is common for
various other flags already.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann
Copy link
Member Author

borkmann commented Jun 6, 2020

test-me-please

@joestringer joestringer merged commit eee8b09 into master Jun 6, 2020
1.8.0 automation moved this from In progress to Merged Jun 6, 2020
@joestringer joestringer deleted the pr/rename-disabled branch June 6, 2020 04:58
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 8, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 9, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/daemon Impacts operation of the Cilium daemon. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
1.8.0
Backport done to v1.8
Development

Successfully merging this pull request may close these issues.

None yet

7 participants