fqdn: Fix missing IsNil checks in unit tests #11953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: 1121202 ("fqdn: L3-aware L7 DNS policy enforcement") Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
area/CI
|
test-me-please |
tklauser
approved these changes
Jun 8, 2020
|
test-focus RuntimePrivilegedUnitTests |
|
|
pchaigno
added
the
ready-to-merge
christarazi
reviewed
Jun 8, 2020
| @@ -325,12 +325,14 @@ func (s *DNSProxyTestSuite) TestRejectNonMatchingRefusedResponse(c *C) { | |||
|
|
|||
| // reject a query with NXDomain | |||
| s.proxy.SetRejectReply(option.FQDNProxyDenyWithNameError) | |||
| response, _, _ := s.dnsTCPClient.Exchange(request, s.proxy.TCPServer.Listener.Addr().String()) | |||
| response, _, err := s.dnsTCPClient.Exchange(request, s.proxy.TCPServer.Listener.Addr().String()) | |||
| c.Assert(err, IsNil, Commentf("DNS request from test client failed when it should succeed")) | |||
There was a problem hiding this comment.
TIL: I didn't know you can pass Commentf to customize the assertion failure :)
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11943
Fixes: #9587
The same error is also present in v1.7 and v1.6 (#9587 was backported), but I'm not sure it's worth backporting to either.