Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Improve session affinity section in kube-proxy free guide #11958

Merged
merged 2 commits into from Jun 8, 2020
Merged

docs: Improve session affinity section in kube-proxy free guide #11958

merged 2 commits into from Jun 8, 2020

Conversation

brb
Copy link
Member

@brb brb commented Jun 8, 2020

@brb brb added priority/release-blocker area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Jun 8, 2020
@brb brb requested a review from pchaigno June 8, 2020 15:07
@brb brb requested a review from a team as a code owner June 8, 2020 15:07
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Jun 8, 2020
@brb brb changed the title docs: Improve session affinity section in kube-proxy free section docs: Improve session affinity section in kube-proxy free guide Jun 8, 2020
brb added 2 commits June 8, 2020 17:08
@brb
docs: Add session affinity map limitations
409c326 
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
docs: Address comments for session affinity section
bcb9dab 
Suggested-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 36.982% when pulling bcb9dab on pr/brb/docs-session-affinity-improvements into 961da39 on master.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 8, 2020
@pchaigno
Copy link
Member

pchaigno commented Jun 8, 2020

Do we want to backport to v1.8?

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 8, 2020
@borkmann borkmann merged commit 6bd92a5 into master Jun 8, 2020
1.8.0 automation moved this from In progress to Merged Jun 8, 2020
@borkmann borkmann deleted the pr/brb/docs-session-affinity-improvements branch June 8, 2020 17:54
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 9, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 9, 2020
@aanm aanm mentioned this pull request Jun 9, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 12, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
1.8.0
Backport done to v1.8
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brb @coveralls @pchaigno @borkmann @aanm