test/K8sServices: Skip checks for externalTrafficPolicy=Local with kube-proxy <1.15 #11965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be-proxy <1.15 kube-proxy <1.15 does not forward node-local traffic for services with externalTrafficPolicy=Local if there are no node-local backends. Therefore we should not test this behavior in CI either. This commit introduces a version check for kube-proxy and only enables the tests on kube-proxy >=1.15. Fixes: 8260696 ("test/K8sServices: skip checks for BPF with externalTrafficPolicy=Local") Fixes: #11948 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added
area/CI
|
test-missed-k8s |
|
test-me-please |
|
(note: this PR fixes |
qmonnet
approved these changes
Jun 8, 2020
pchaigno
approved these changes
Jun 9, 2020
aanm
approved these changes
Jun 9, 2020
aanm
deleted the
pr/gandro/ci-node-local-kube-proxy-externaltrafficypolicy
branch
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kube-proxy <1.15 does not forward node-local traffic for services
with
externalTrafficPolicy=Localif there are no node-local backends.Therefore we should not test this behavior in CI either. This commit
introduces a version check for kube-proxy and only enables the tests on
kube-proxy >=1.15.
Fixes: 8260696 ("test/K8sServices: skip checks for BPF with externalTrafficPolicy=Local")
Fixes: #11948
/cc @qmonnet @brb