Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: don't check destination label in RuntimePolicies with PolicyAuditMode #12003

Merged
merged 1 commit into from Jun 10, 2020

Conversation

tklauser
Copy link
Member

It might rarely happen that the host starts pinging fast enough that
the endpoint still has identity "init" / 5. This currently leads to fail
the test.

As already done in the egress case, ignore the destination labels when
checking the hubble observe output.

Fixes #11954

@tklauser tklauser added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. ci/flake This is a known failure that occurs in the tree. Please investigate me! labels Jun 10, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Jun 10, 2020
@tklauser
Copy link
Member Author

test-focus RuntimePolicies

Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

test/runtime/Policies.go Outdated Show resolved Hide resolved
@tklauser tklauser force-pushed the pr/tklauser/runtime-policies-wait-endpoint-identity branch from c3e2d41 to 8fecc32 Compare June 10, 2020 12:15
…itMode

It might rarely happen that the host starts pinging fast enough that
the endpoint still has identity "init" / 5. This currently leads to fail
the test.

As already done in the egress case, ignore the destination labels when
checking the hubble observe output.

Fixes #11954

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser force-pushed the pr/tklauser/runtime-policies-wait-endpoint-identity branch from 8fecc32 to a63a19a Compare June 10, 2020 12:19
@tklauser tklauser marked this pull request as ready for review June 10, 2020 12:19
@tklauser tklauser requested a review from a team as a code owner June 10, 2020 12:19
@tklauser
Copy link
Member Author

test-me-please

@b3a-dev b3a-dev added this to In Progress (Cilium) in CI Force via automation Jun 10, 2020
@coveralls
Copy link

coveralls commented Jun 10, 2020

Coverage Status

Coverage increased (+0.02%) to 37.06% when pulling a63a19a on pr/tklauser/runtime-policies-wait-endpoint-identity into 1319eff on master.

@tklauser
Copy link
Member Author

tklauser commented Jun 10, 2020

retest-runtime (previous failure: https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/723)

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 10, 2020
@nebril nebril merged commit 027ea95 into master Jun 10, 2020
1.8.0 automation moved this from In progress to Merged Jun 10, 2020
CI Force automation moved this from In Progress (Cilium) to Fixed / Done Jun 10, 2020
@nebril nebril deleted the pr/tklauser/runtime-policies-wait-endpoint-identity branch June 10, 2020 16:26
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 19, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 21, 2020
@aanm aanm mentioned this pull request Jun 21, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 22, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me! ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.8.0
  
Merged
1.8.0
Backport done to v1.8
CI Force
  
Fixed / Done
Development

Successfully merging this pull request may close these issues.

CI: RuntimePolicies: Init Policy Default Drop Test With PolicyAuditMode tests ingress
7 participants