cilium: fix encryption flow labels in ip6 case #12015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please set the appropriate release note label. |
|
test-focus K8sDatapathConfig.transparent |
…stack Avoid adding extra marks and labels to ip6 packets which can result in dropped packets in ip6 case. Signed-off-by: John Fastabend <john.fastabend@gmail.com>
|
test-focus K8sDatapathConfig.transparent |
joestringer
added
the
release-note/bug
joestringer
reviewed
Jun 11, 2020
|
test-focus K8sDatapathConfig |
|
Doing a preliminary test on datapath configurations I have what I believe is an unrelated issue with my local cluster but above runs in gke cluster. The patch is good I believe and the local cluster issue seems to be related to iptables/route/mtu conflicts somehow. I get spurious TCP reset both with above patch and before. |
|
build error when encap is not enabled :( but on the plus side transparent encryption + vxlan passed. I'll push an update and rerun. |
|
test-me-please |
joestringer
approved these changes
Jun 11, 2020
|
hit #10929 |
1 similar comment
|
hit #10929 |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to attach ip6 flow labels and set mark fields if the packet is only going to the stack to be encrypted. So short circuit the pass_to_stack logic after we decide the packet needs encryption and send directly to stack.
Also fix up DatapathConfiguration tests so they run on my local cluster and are in-sync with tests that do not use encryption.