Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: Clean up the hubble-relay DNS name in the UI chart #12033

Merged
merged 1 commit into from Jun 18, 2020
Merged

helm: Clean up the hubble-relay DNS name in the UI chart #12033

merged 1 commit into from Jun 18, 2020

Conversation

michi-covalent
Copy link
Contributor

Specifying the service name by itself as the DNS is sufficient since
hubble-relay and hubble-ui get deployed to the same namespace.

Signed-off-by: Michi Mutsuzaki michi@isovalent.com

@michi-covalent michi-covalent added dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay area/helm Impacts helm charts and user deployment experience labels Jun 11, 2020
@michi-covalent michi-covalent requested review from a team June 11, 2020 23:53
@michi-covalent michi-covalent requested a review from a team as a code owner June 11, 2020 23:53
@michi-covalent michi-covalent requested a review from a team June 11, 2020 23:53
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Jun 11, 2020
@coveralls
Copy link

coveralls commented Jun 12, 2020 •
edited

Coverage Status

Coverage decreased (-0.03%) to 37.035% when pulling 41c5a0a on pr/michi/relay into 17b597d on master.

christarazi
christarazi approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@glibsm glibsm added backport/1.8 and removed dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs labels Jun 12, 2020
@aanm aanm added dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs and removed backport/1.8 labels Jun 12, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 15, 2020
@gandro
Copy link
Member

gandro commented Jun 15, 2020

test-me-please

gandro
gandro requested changes Jun 15, 2020
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved a bit too early, can you also remove the corresponding value, since it is now unused?

cilium/install/kubernetes/cilium/charts/hubble-ui/values.yaml

Line 11 in a1ccadb

clusterDomain: cluster.local

nebril
nebril reviewed Jun 15, 2020
View reviewed changes
Copy link
Member

@nebril nebril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as Sebastian, LGTM otherwise.

@michi-covalent
helm: Clean up the hubble-relay DNS name in the UI chart
41c5a0a 
Specifying the service name by itself as the DNS is sufficient since
hubble-relay and hubble-ui get deployed to the same namespace.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
aanm
aanm reviewed Jun 17, 2020
View reviewed changes
Copy link
Member

@aanm aanm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to backport this to 1.8 then it does not need to wait for the 1.8.0 release.

@aanm aanm removed the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Jun 17, 2020
@aanm
Copy link
Member

aanm commented Jun 17, 2020

test-me-please

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 17, 2020
@aanm aanm merged commit d28767b into master Jun 18, 2020
1.8.0 automation moved this from In progress to Merged Jun 18, 2020
@aanm aanm deleted the pr/michi/relay branch June 18, 2020 10:18
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 18, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 18, 2020
@jrajahalme jrajahalme mentioned this pull request Jun 18, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 18, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril left review comments

@aanm aanm aanm left review comments

@gandro gandro gandro approved these changes

@rolinh rolinh rolinh approved these changes

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
No open projects
1.8.0
  
Merged
1.8.0
Backport done to v1.8
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@michi-covalent @coveralls @gandro @aanm @rolinh @nebril @christarazi @glibsm @borkmann