test: Fix hubble-relay tag pull for release branches #12034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the CI framework we build images from the current tree and tag them as `latest`, even if the current tree is for instance `v1.8` (with version `v1.8.0-rc2`). At the same time, the Helm charts in the tree specify in the files that they will pull the current tag from `VERSION`, for instance right now on v1.8 branch, `v1.8.0-rc2`. For `cilium` and `operator` images, we *override* the helm chart defaults with `latest` to pick up the build/cached images from the first step above. So `latest` contains the version built from `v1.8`. However we weren't doing this for Hubble Relay, which meant that it tried to pull the image with the tag `v1.8.0-rc2` but this image didn't exist in the local registry. To fix this and get the v1.8 tree to properly build with a version of hubble-relay from v1.8 branch, we must tag, cache and deploy images that represent the latest v1.8 development with `latest`, and pull that image from the CI framework, and explicitly *not* pull the v1.8 version which is specified in the helm charts. :exploding_head: Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
added
release-note/misc
|
test-focus K8sHubbleTest |
rolinh
approved these changes
Jun 12, 2020
maintainer-s-little-helper
bot
moved this from Backport done to v1.8
to Needs backport from master
in 1.8.0
|
It was backported in #12027 |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.8
in 1.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(The following was written from the perspective of the v1.8 branch)
In the CI framework we build images from the current tree and tag them
as
latest, even if the current tree is for instancev1.8(withversion
v1.8.0-rc2).At the same time, the Helm charts in the tree specify in the files that
they will pull the current tag from
VERSION, for instance right nowon v1.8 branch,
v1.8.0-rc2.For
ciliumandoperatorimages, we override the helm chartdefaults with
latestto pick up the build/cached images from the firststep above. So
latestcontains the version built fromv1.8.However we weren't doing this for Hubble Relay, which meant that it
tried to pull the image with the tag
v1.8.0-rc2but this image didn'texist in the local registry.
To fix this and get the v1.8 tree to properly build with a version of
hubble-relay from v1.8 branch, we must tag, cache and deploy images that
represent the latest v1.8 development with
latest, and pull that imagefrom the CI framework, and explicitly not pull the v1.8 version which
is specified in the helm charts.
馃く