Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Extend kubeproxy-free GSG wrt multi-dev #12054

Merged
merged 2 commits into from Jun 15, 2020
Merged

docs: Extend kubeproxy-free GSG wrt multi-dev #12054

merged 2 commits into from Jun 15, 2020

Conversation

brb
Copy link
Member

@brb brb commented Jun 12, 2020 •
edited

This PR:

  • Adds direct routing device to KubeProxyReplacement in cilium status (denoted with (DR)).
  • Extends the kube-proxy free GSG wrt multi-dev setup.

@brb brb added pending-review area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. labels Jun 12, 2020
@brb brb requested a review from borkmann June 12, 2020 15:00
@brb brb requested a review from a team as a code owner June 12, 2020 15:00
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

4 similar comments
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Jun 12, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 12, 2020
@brb brb added the release-note/misc This PR makes changes that have no direct user impact. label Jun 12, 2020
@borkmann
Copy link
Member

Please also add a full new GSG sub-section including setup-verification for multi-dev howto for the scenarios of public iface exposed to world and private for backends.

@coveralls
Copy link

coveralls commented Jun 12, 2020 •
edited

Coverage Status

Coverage decreased (-0.02%) to 37.028% when pulling ca338e8 on pr/brb/docs-multi-dev into 5637e0e on master.

pchaigno
pchaigno approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides what Daniel already mentioned ☝️

Documentation/gettingstarted/kubeproxy-free.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/kubeproxy-free.rst Outdated Show resolved Hide resolved
@brb
Copy link
Member Author

brb commented Jun 15, 2020

Removing the release-blocker label, as it's a documentation change which can be merged after we release the v1.8.0 image and still be shown in the docs.

@brb
api,daemon,cli: Add DirectRoutingDevice to KubeProxyReplacement status
b0a6b86 
Such device is denoted with "(DR)", e.g.:

    KubeProxyReplacement:   Strict   [eth0 (DR), eth1]   [NodePort
    (SNAT, 30000-32767, XDP: DISABLED), HostPort, ExternalIPs,
    HostReachableServices (TCP, UDP), SessionAffinity]

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb requested a review from a team June 15, 2020 14:43
@brb brb requested a review from a team as a code owner June 15, 2020 14:43
@brb brb requested review from borkmann and pchaigno June 15, 2020 14:44
@brb
Copy link
Member Author

brb commented Jun 15, 2020

test-me-please

@brb
Copy link
Member Author

brb commented Jun 15, 2020

Please also add a full new GSG sub-section including setup-verification for multi-dev howto for the scenarios of public iface exposed to world and private for backends.

Extended the existing section to avoid overbloating the guide.

@brb
docs: Extend kubeproxy-free GSG wrt multi-dev
ca338e8 
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@borkmann borkmann merged commit fe4e456 into master Jun 15, 2020
1.8.0 automation moved this from In progress to Merged Jun 15, 2020
@borkmann borkmann deleted the pr/brb/docs-multi-dev branch June 15, 2020 17:47
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 16, 2020
@borkmann borkmann mentioned this pull request Jun 16, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@pchaigno pchaigno Awaiting requested review from pchaigno

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
1.8.0
Backport done to v1.8
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brb @borkmann @coveralls @pchaigno