daemon: Fix fallback to iptables-based masquerading #12081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when falling back to iptables-based masquerading, if a user had specified --egress-masquerade-interface, the agent considered it as part of BPF masquerading options. This made it obviously to fail. Fix: b7b962b ("daemon: Fallback to iptables if BPF masq cannot be enabled") Reported-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
Please set the appropriate release note label. |
4 similar comments
|
Please set the appropriate release note label. |
|
Please set the appropriate release note label. |
|
Please set the appropriate release note label. |
|
Please set the appropriate release note label. |
|
test-me-please |
brb
added
the
release-note/bug
|
test-me-please |
To avoid breaking existing guides, fallback to iptables-based masquerading if --egress-masquerade-interface is set. In v1.9, we plan to add a support for the flag which will make the transition from BPF to iptables -based masquerading transparent when the flag is set. Signed-off-by: Martynas Pumputis <m@lambda.lt>
nebril
approved these changes
Jun 16, 2020
tklauser
approved these changes
Jun 16, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when falling back to iptables-based masquerading, if a user
had specified
--egress-masquerade-interface, the agent considered itas part of BPF masquerading options. This made it obviously to fail.
Fix: b7b962b ("daemon: Fallback to iptables if BPF masq cannot be enabled")
Reported-by: Tobias Klauser tklauser@distanz.ch
Fix #12081
/cc @tklauser