Fix GKE Helm options for CI and docs. #12087
Conversation
jrajahalme
added
area/documentation
|
test-gke |
|
test-me-please |
| @@ -92,7 +92,7 @@ below. This will ensure all pods are managed by Cilium. | |||
| --set global.cni.binPath=/home/kubernetes/bin \\ | |||
| --set global.gke.enabled=true \\ | |||
| --set config.ipam=kubernetes \\ | |||
| --set global.native-routing-cidr=$NATIVE_CIDR | |||
| --set global.nativeRoutingCIDR=$NATIVE_CIDR | |||
There was a problem hiding this comment.
Note that we need this particular change on v1.7 as well (but not the ipam option). Given you're on backports this week, probably easiest for you to make sure the right commit from this PR goes back.
There was a problem hiding this comment.
Actually, it looks like we backported this change to the docs but never backported the helm side interpretation so it has been a no-op the entire time 🤦
|
test-gke |
|
Pushed one more commit only touching the GKE jenkinsfile after all other CI jobs already succeeded. |
|
test-gke |
1 similar comment
|
test-gke |
|
@nebril added one more commit to pass Hubble-relay image with the proper tag to Ginkgo, please have a look! |
|
test-gke |
|
This needs #12076, waiting it to get merged before rebasing. |
jrajahalme
force-pushed
the
pr/jrajahalme/gke-fixes
branch
from
92a1fc9
to
f7fbf0a
Compare
|
rebased, retesting.. |
|
test-gke |
|
5 failures in https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/1687/ |
|
test-gke |
…docs Basic regular expressions in sed do not support '+', while the command line arguments for extended regular expressions are different for GNU sed and Mac OSX. Use (unquoted) '*' instead, as there is no harm replacing '[]' with '[]'. This form work both on Linux and Mac OSX. Add a note to the e2e testing docs so that users know to run the script if namespaces get stuck at 'Terminating'. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
GKE can time out on apply when installing Cilium, use a longer timeout. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Create the cluster lock in namespace 'cilium-ci-lock' instead of 'default' so that it survives the CI deleting all resources in the default namespace: 15:57:58 22:57:57 STEP: Deleting rs [lock-6f4fb6cdfb] in namespace default 15:57:58 22:57:57 STEP: Waiting for 1 deletes to return (lock-6f4fb6cdfb) 15:57:58 22:57:57 STEP: Deleting deployment [lock] in namespace default 15:57:58 22:57:57 STEP: Waiting for 1 deletes to return (lock) Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
force-pushed
the
pr/jrajahalme/gke-fixes
branch
from
0214ce8
to
af11191
Compare
|
test-me-please |
|
test-gke |
|
rebased, no changes |
|
test-gke |
1 similar comment
|
test-gke |
|
The only change here that can affect non-GKE tests is the doubling of the Apply timeout from 30 seconds to 60 seconds. Due to the cluster locking bug all GKE test runs can step on each other at any time until this PR is merged and all PRs are rebased to include the locking fix. There has been many successful GKE CI runs, but AFAIK all of them have been on cluster Given the above this PR is ready merge. |
maintainer-s-little-helper
bot
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.6
GKE install guide specifies the "ipam.config=kubernetes" option while
CI gkeHelmOverrides do not. Adding this option to CI gkeHelmOverrides
allowed Ginkgo runs in GKE to succeed.
Helm name for the native routing CIDR is
"global.nativeRoutingCIDR". Cilium agent command line option name is
"native-routing-cidr".
Fixes: #12053