New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Misc fixups for Transparent Encryption GSG #12088
doc: Misc fixups for Transparent Encryption GSG #12088
Conversation
Please set the appropriate release note label. |
Please set the appropriate release note label. |
Please set the appropriate release note label. |
2 similar comments
Please set the appropriate release note label. |
Please set the appropriate release note label. |
test-docs-please |
df766e5
to
7b9f618
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit below; 👍 otherwise!
(Finally, a native speaker who uses commas 🎉 That really helps to quickly parse sentences, not being a native speaker.)
Commit 592df99ad890b172d273421f9b4f6b6fa3b6454a does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Signed-off-by: Chris Tarazi <chris@isovalent.com>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
592df99
to
2d0a508
Compare
Travis hit #12111 |
--set global.tunnel=vxlan \ | ||
--set global.encryption.enabled=true \ | ||
--set global.encryption.nodeEncryption=false | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its probably preferred to run GKE with direct routing but having an example is nice. We can add a direct routing example later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we still add one as follow-up, so we don't loose track of it? Thx
Updates #11903