Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Misc fixups for Transparent Encryption GSG #12088

Merged

Conversation

christarazi
Copy link
Member

Updates #11903

@christarazi christarazi requested a review from a team as a code owner June 16, 2020 00:06
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@christarazi christarazi added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Jun 16, 2020
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

2 similar comments
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 16, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.7.6 Jun 16, 2020
@christarazi christarazi added the release-note/misc This PR makes changes that have no direct user impact. label Jun 16, 2020
@christarazi
Copy link
Member Author

test-docs-please

@christarazi christarazi force-pushed the pr/christarazi/misc-fixups-enc-docs branch 2 times, most recently from df766e5 to 7b9f618 Compare June 16, 2020 00:28
@b3a-dev b3a-dev mentioned this pull request Jun 16, 2020
20 tasks
@coveralls
Copy link

coveralls commented Jun 16, 2020

Coverage Status

Coverage decreased (-0.05%) to 37.023% when pulling 2d0a508 on christarazi:pr/christarazi/misc-fixups-enc-docs into 331aab4 on cilium:master.

Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit below; 👍 otherwise!

(Finally, a native speaker who uses commas 🎉 That really helps to quickly parse sentences, not being a native speaker.)

Documentation/gettingstarted/encryption.rst Outdated Show resolved Hide resolved
@maintainer-s-little-helper
Copy link

Commit 592df99ad890b172d273421f9b4f6b6fa3b6454a does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 16, 2020
Signed-off-by: Chris Tarazi <chris@isovalent.com>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi force-pushed the pr/christarazi/misc-fixups-enc-docs branch from 592df99 to 2d0a508 Compare June 16, 2020 16:32
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 16, 2020
@christarazi
Copy link
Member Author

Travis hit #12111

--set global.tunnel=vxlan \
--set global.encryption.enabled=true \
--set global.encryption.nodeEncryption=false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its probably preferred to run GKE with direct routing but having an example is nice. We can add a direct routing example later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we still add one as follow-up, so we don't loose track of it? Thx

@borkmann borkmann merged commit dc4f549 into cilium:master Jun 16, 2020
1.8.0 automation moved this from In progress to Merged Jun 16, 2020
@christarazi christarazi deleted the pr/christarazi/misc-fixups-enc-docs branch June 17, 2020 00:28
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 18, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 18, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.6 Jun 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.6 Jun 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.6 Jun 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.6 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.7.6
Backport done to v1.7
1.8.0
  
Merged
1.8.0
Backport done to v1.8
Development

Successfully merging this pull request may close these issues.

None yet

7 participants