daemon: Fix session affinity map creation #12134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
pending-review
area/daemon
|
test-me-please |
aanm
approved these changes
Jun 17, 2020
tklauser
approved these changes
Jun 17, 2020
|
retest-4.19 |
joestringer
approved these changes
Jun 17, 2020
|
K8sDatapathConfig Etcd Check connectivity failure: |
Known CI flake on 4.19; I think not tracked yet though. |
|
retest-4.19 |
|
4.19 hit the same Etcd flake. |
|
test-me-please |
brb
force-pushed
the
pr/brb/fix-kube-proxy-init
branch
from
e0111ae
to
34c4247
Compare
|
Hit |
|
retest-net-next |
brb
force-pushed
the
pr/brb/fix-kube-proxy-init
branch
from
34c4247
to
4561293
Compare
|
test-me-please |
- Add session affinity to auto-{enable,disable} msgs.
- Make more clear that auto-enabling does not guarantee that the listed
features will be enabled.
Signed-off-by: Martynas Pumputis <m@lambda.lt>
And move all related helpers from cmd/daemon_main.go into cmd/kube_proxy_replacement.go to not bloat over the former. Signed-off-by: Martynas Pumputis <m@lambda.lt>
Previously, initKubeProxyReplacementOptions() was called after
initMaps() which when running with --kube-proxy-replacement=probe and
--enable-session-affinity=false resulted in the session affinity -related
BPF maps not being created.
An example error log message which illustrated that:
level=warning msg="Unable to add entry to
affinity match map" backendID=5 error="Unable to get object
/sys/fs/bpf/tc/globals/cilium_lb_affinity_match: no such file or
directory" serviceID=11 subsys=service
Fixes: bcdcf9b ("daemon: Move kubeProxyReplacement init after connect to k8s")
Reported-by: Jarno Rajahalme <jarno@covalent.io>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the BPF session affinity -related maps creation, improves logging of auto detection and moves the replacement helpers into
cmd/kube_proxy_replacement.go.Reviewable per commit.
Fixes: bcdcf9b ("daemon: Move kubeProxyReplacement init after connect to k8s")
Reported-by: Jarno Rajahalme jarno@covalent.io
Fix #12118.