Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: NodePort XDP on AWS #12156

Merged
merged 1 commit into from Jun 17, 2020
Merged

docs: NodePort XDP on AWS #12156

merged 1 commit into from Jun 17, 2020

Conversation

borkmann
Copy link
Member

Write up a small getting started guide based on Tobias' notes on
EKS (https://gist.github.com/tklauser/268641aea4fced9e8c3b4a2f7536661b).

Signed-off-by: Tobias Klauser tklauser@distanz.ch
Signed-off-by: Daniel Borkmann daniel@iogearbox.net

@borkmann borkmann added pending-review area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. labels Jun 17, 2020
@borkmann borkmann requested a review from a team as a code owner June 17, 2020 21:50
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

3 similar comments
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Jun 17, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 17, 2020
@borkmann borkmann added the release-note/misc This PR makes changes that have no direct user impact. label Jun 17, 2020
@borkmann borkmann force-pushed the pr/xdp-eks-doc branch 4 times, most recently from ba27208 to 0bc8fdc Compare June 17, 2020 22:05
Write up a small getting started guide based on Tobias' notes on
EKS (https://gist.github.com/tklauser/268641aea4fced9e8c3b4a2f7536661b).

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
The default MTU is set to 9001 on the ena driver. Given XDP buffers are linear, they
operate on a single page. A driver typically reserves some headroom for XDP as well
(e.g. for encapsulation purpose), therefore, the highest possible MTU for XDP would
be 3818.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limitation is a bit unfortunate. I wonder if we should add an option to configure mtu for 1.9?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the agent could take care of it for 1.9.

Combined: 4

In order to use XDP the channels must be set to at most 1/2 of the value from
``Combined`` above. Both, MTU and channel changes are applied as follows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc some drivers will automagically reconfigure to meet the rx/tx queue requirements perhaps we should file a feature request against ena to do this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, either that or implement it directly upstream. E.g. on Azure no additional knobs are needed.

Copy link
Contributor

@jrfastab jrfastab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM perhaps in future release we can make this a bit more seamless but this is awesome to see XDP being used here.

@borkmann borkmann merged commit 1ca7a16 into master Jun 17, 2020
1.8.0 automation moved this from In progress to Merged Jun 17, 2020
@borkmann borkmann deleted the pr/xdp-eks-doc branch June 17, 2020 22:23
@coveralls
Copy link

coveralls commented Jun 17, 2020

Coverage Status

Coverage increased (+0.04%) to 37.132% when pulling 33468d1 on pr/xdp-eks-doc into 62eb008 on master.

@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 18, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 18, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
1.8.0
Backport done to v1.8
Development

Successfully merging this pull request may close these issues.

None yet

4 participants