New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: sync CiliumNodes into etcd instead of k8s nodes #12179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please set the appropriate release note label. |
test-focus K8sDatapathConfig |
test-4.19 |
Signed-off-by: André Martins <andre@cilium.io>
As Cilium is more dependent on the CiliumNodes information to be more up to date, the Cilium Operator should sync those nodes into the KVStore instead of the k8s nodes. Using k8s nodes is not reliable as some of the fields set in these structures are not up to date with the fields set in the Cilium Nodes. Signed-off-by: André Martins <andre@cilium.io>
test-me-please |
aanm
changed the title
pkg/nodediscovery: print node when registering it into the cluster
operator: sync CiliumNodes into etcd instead of k8s nodes
Jun 18, 2020
aanm
added
kind/bug
This is a bug in the Cilium logic.
needs-backport/1.8
release-note/bug
This PR fixes an issue in a previous release of Cilium.
labels
Jun 18, 2020
test-gke wrong tab, ignore |
qmonnet
approved these changes
Jun 18, 2020
christarazi
approved these changes
Jun 18, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
Jun 18, 2020
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/bug
This is a bug in the Cilium logic.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operator: sync cilium nodes to kvstore instead of k8s nodes
As Cilium is more dependent on the CiliumNodes information to be more up
to date, the Cilium Operator should sync those nodes into the KVStore
instead of the k8s nodes. Using k8s nodes is not reliable as some of the
fields set in these structures are not up to date with the fields set in
the Cilium Nodes.
Signed-off-by: André Martins andre@cilium.io