Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: sync CiliumNodes into etcd instead of k8s nodes #12179

Merged
merged 2 commits into from Jun 18, 2020

Conversation

aanm
Copy link
Member

@aanm aanm commented Jun 18, 2020

operator: sync cilium nodes to kvstore instead of k8s nodes

As Cilium is more dependent on the CiliumNodes information to be more up
to date, the Cilium Operator should sync those nodes into the KVStore
instead of the k8s nodes. Using k8s nodes is not reliable as some of the
fields set in these structures are not up to date with the fields set in
the Cilium Nodes.

Signed-off-by: André Martins andre@cilium.io

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@aanm
Copy link
Member Author

aanm commented Jun 18, 2020

test-focus K8sDatapathConfig

@aanm
Copy link
Member Author

aanm commented Jun 18, 2020

test-4.19

aanm added 2 commits June 18, 2020 16:03
Signed-off-by: André Martins <andre@cilium.io>
As Cilium is more dependent on the CiliumNodes information to be more up
to date, the Cilium Operator should sync those nodes into the KVStore
instead of the k8s nodes. Using k8s nodes is not reliable as some of the
fields set in these structures are not up to date with the fields set in
the Cilium Nodes.

Signed-off-by: André Martins <andre@cilium.io>
@aanm
Copy link
Member Author

aanm commented Jun 18, 2020

test-me-please

@aanm aanm changed the title pkg/nodediscovery: print node when registering it into the cluster operator: sync CiliumNodes into etcd instead of k8s nodes Jun 18, 2020
@aanm aanm added kind/bug This is a bug in the Cilium logic. needs-backport/1.8 release-note/bug This PR fixes an issue in a previous release of Cilium. labels Jun 18, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 18, 2020
@aanm aanm marked this pull request as ready for review June 18, 2020 14:04
@aanm aanm requested review from a team as code owners June 18, 2020 14:04
@aanm aanm requested a review from a team June 18, 2020 14:04
@aanm aanm requested a review from a team as a code owner June 18, 2020 14:04
@aanm
Copy link
Member Author

aanm commented Jun 18, 2020

test-gke wrong tab, ignore

@aanm aanm merged commit 6d44f4c into cilium:master Jun 18, 2020
1.8.0 automation moved this from In progress to Merged Jun 18, 2020
@aanm aanm deleted the pr/fix-etcd-routes branch June 18, 2020 17:47
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 18, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.8.0
  
Merged
1.8.0
Backport done to v1.8
Development

Successfully merging this pull request may close these issues.

None yet

4 participants