-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: configurable annotations for agent and operator pods #12189
Conversation
Please set the appropriate release note label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, one minor comment below.
Signed-off-by: Maxime VISONNEAU <maxime.visonneau@gmail.com>
1643eaf
to
8e32f4a
Compare
smoke tests passed, merging |
is there any plan to backport this PR in |
@mvisonneau just wanted to let you know that the prevailing spelling for most helm charts out there seems to be |
oh indeed @dominik318, I'll submit another PR to amend! I reckon it is still fine to change it given that it hasn't been backported yet 🤷 |
Glad we caught the typo before pushing it into a release :-) We discussed on #13458 to make these changes available in a subsequent v1.8.x release, assuming @mvisonneau prepares the changes against the v1.8 branch. |
This change follows-up onto cilium#12189 (comment) Signed-off-by: Maxime VISONNEAU <maxime.visonneau@gmail.com>
This change follows-up onto #12189 (comment) Signed-off-by: Maxime VISONNEAU <maxime.visonneau@gmail.com>
This change allows the enduser to specify arbitrary annotations for the agent and operator pods. This is not necessarily Cilium related but is for example a prerequisite to get Datadog autodiscovery configured. Thanks to this change, it gets as "simple" as: