Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adjust policy verdict log output examples to new format #12256

Merged
merged 1 commit into from Jun 24, 2020
Merged

docs: adjust policy verdict log output examples to new format #12256

merged 1 commit into from Jun 24, 2020

Conversation

tklauser
Copy link
Member

Commit 0ce6480 ("monitor: Shorten policy-verdict output") changed
the format of the policy verdict log output. Adjust the example output
in the contribution guide and the GSGs to the new format.

@tklauser
docs: adjust policy verdict log output examples to new format
37092c9 
Commit 0ce6480 ("monitor: Shorten policy-verdict output") changed
the format of the policy verdict log output. Adjust the example output
in the contribution guide and the GSGs to the new format.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.8 labels Jun 24, 2020
@tklauser tklauser requested a review from pchaigno June 24, 2020 10:16
@tklauser tklauser requested review from a team as code owners June 24, 2020 10:16
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Jun 24, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 24, 2020
pchaigno
pchaigno approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tklauser!

@pchaigno
Copy link
Member

Documentation test is passing. Marking as ready to merge.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 24, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 37.19% when pulling 37092c9 on pr/tklauser/docs-policy-verdict-log-examples into 55dd1b9 on master.

@aanm aanm merged commit 9c0897b into master Jun 24, 2020
1.8.0 automation moved this from In progress to Merged Jun 24, 2020
@aanm aanm deleted the pr/tklauser/docs-policy-verdict-log-examples branch June 24, 2020 11:50
This was referenced Jun 24, 2020
Closed
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 24, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 24, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 24, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 24, 2020
rolinh added a commit that referenced this pull request Aug 5, 2020
@rolinh
Revert "docs: adjust policy verdict log output examples to new format"
06f239c 
This reverts commit 7728f5e.

It was backported by mistake as the new policy verdict output format is
a change in v1.9.

Ref: #12256

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh mentioned this pull request Aug 5, 2020
Merged
aanm pushed a commit that referenced this pull request Aug 5, 2020
@rolinh @aanm
Revert "docs: adjust policy verdict log output examples to new format"
f033c90 
This reverts commit 7728f5e.

It was backported by mistake as the new policy verdict output format is
a change in v1.9.

Ref: #12256

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
1.8.0
Backport done to v1.8
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tklauser @pchaigno @coveralls @errordeveloper @borkmann @aanm